Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging-sentry: Add config option for "server_name" #13412

Closed
medvedev opened this issue Nov 21, 2020 · 6 comments
Closed

logging-sentry: Add config option for "server_name" #13412

medvedev opened this issue Nov 21, 2020 · 6 comments
Labels
Milestone

Comments

@medvedev
Copy link
Contributor

Description
Target extension: logging-sentry
Currently all the events in sentry have "server_name:localhost". Probably, it's a default value.
Proposal is to add a config option for sentry's server_name and pass it with every event.

Implementation ideas
Add config option log.sentry.server-name and use it for DefaultSentryClientFactory.SERVERNAME_OPTION in iSentryConfigProvider.getProperty(String key)

@medvedev medvedev added the kind/enhancement New feature or request label Nov 21, 2020
@ghost ghost added the triage/needs-triage label Nov 21, 2020
medvedev added a commit to medvedev/quarkus that referenced this issue Nov 21, 2020
@gsmet
Copy link
Member

gsmet commented Nov 21, 2020

@medvedev are you interested in contributing this feature? It should be easy enough.

@gsmet
Copy link
Member

gsmet commented Nov 21, 2020

Ah ah, I see you're working on it :).

medvedev added a commit to medvedev/quarkus that referenced this issue Nov 21, 2020
@medvedev
Copy link
Contributor Author

@gsmet can you please check the PR?
#13414

medvedev added a commit to medvedev/quarkus that referenced this issue Nov 22, 2020
@Erfankam
Copy link

I m interested to work on this issue. How to assign issue to myself?

@medvedev
Copy link
Contributor Author

@Erfankam the PR is already merged. But you can pick other Sentry's options from DefaultSentryClientFactory stack and make them configurable in Quarkus, in scope of a separate ticket.

@machi1990
Copy link
Member

Closed by #13414

@gsmet gsmet added this to the 1.11 - master milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants