Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarkus-smallrye-jwt-build as quarkus-smallrye-jwt dependency #14803

Closed
rsvoboda opened this issue Feb 3, 2021 · 3 comments · Fixed by #14804
Closed

Add quarkus-smallrye-jwt-build as quarkus-smallrye-jwt dependency #14803

rsvoboda opened this issue Feb 3, 2021 · 3 comments · Fixed by #14804
Assignees
Milestone

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Feb 3, 2021

Add quarkus-smallrye-jwt-build as dependency of quarkus-smallrye-jwt

This is followup for #13626 change to avoid need to explicitly add quarkus-smallrye-jwt-build dependency into pom.xml of existing applications which are using this API.

This way it will be transparent for existing users and new users can still select just quarkus-smallrye-jwt-build.

Docs should be also updated to include info that quarkus-smallrye-jwt-build can be excluded when users do not need that API in their application.

@rsvoboda rsvoboda added the kind/enhancement New feature or request label Feb 3, 2021
@ghost
Copy link

ghost commented Feb 3, 2021

@sberyozkin
Copy link
Member

@rsvoboda thank you, I agree, I suppose dropping it was too forceful at this stage and indeed some users did get caught by it because I also missed updating the migration guide.
So I'll put it back and will also update the docs.
I will open a new issue to drop in in Quarkus 2.0 :-)

@LuccaPrado
Copy link
Contributor

Hey, we need just to update quarkus guides, as the security jwt still referring to quarkus-smallrye-jwt-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants