-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create quarkus-smallrye-jwt-build extension #13626
Create quarkus-smallrye-jwt-build extension #13626
Conversation
I've tested the failing oidc integration tests with |
Hmm, all of these tests work for me in the native mode... |
04a78fe
to
e2f9483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This extension kinda relates to https://github.com/quarkiverse/quarkiverse-jjwt-jackson that @gsmet created? |
@gastaldi that extension is indeed related in that it may be able to do some parts of what the smallrye-jwt build extension can. But it is not part of the smallrye-jwt strategy. |
I need to tweak the deployment package name a bit |
e2f9483
to
52d1b0c
Compare
@sberyozkin don't see any note about this in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.11 You mentioned in the description: "I'll also update the migration notes for 11.0.0.Final that those quarkus-smallrye-jwt users who also require creating JWT tokens will need to add a quarkus-smallrye-jwt-build dependency" |
@rsvoboda sorry, missed it, nothing escapes QE :-). |
Fixes #13499
This PR adds a light-weight
quarkus-smallrye-jwt-build
extension which will help users create JWT tokens with the smallrye-jwt build API in the native mode.I've excluded
smallrye-jwt-build
from thesmallrye-jwt
dependency as none of the latter's code depends on it - it just has been there before it was moved into its own module - many smallrye-jwt users should benefit; I'll also update the migration notes for11.0.0.Final
that thosequarkus-smallrye-jwt
users who also require creating JWT tokens will need to add aquarkus-smallrye-jwt-build
dependency if this specific change is approved;Also updated
quarkus-smallrye-jwt
andquarkus-oidc
deployment code and removedsmallrye-jwt-build
related code and the docs - quickstarts PR to match it will also be opened shortly.I'll update the soon to be PR-ed
quarkus-oidc-client
with thequarkus-smallrye-jwt-build
dependency asap after the merge as well - as I'll need to support the client credentials JWT authentication there (similarly to howquarkus-oidc
does it).Tests which depend on this API are run in
quarkus-smallrye-jwt/deployment
,integration-test/oidc-code-flow
,integration-test/oidc-tenancy
and in thequickstarts/security-jwt-quickstart