Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create quarkus-smallrye-jwt-build extension #13626

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Dec 2, 2020

Fixes #13499

This PR adds a light-weight quarkus-smallrye-jwt-build extension which will help users create JWT tokens with the smallrye-jwt build API in the native mode.

I've excluded smallrye-jwt-build from the smallrye-jwt dependency as none of the latter's code depends on it - it just has been there before it was moved into its own module - many smallrye-jwt users should benefit; I'll also update the migration notes for 11.0.0.Final that those quarkus-smallrye-jwt users who also require creating JWT tokens will need to add a quarkus-smallrye-jwt-build dependency if this specific change is approved;

Also updated quarkus-smallrye-jwt and quarkus-oidc deployment code and removed smallrye-jwt-build related code and the docs - quickstarts PR to match it will also be opened shortly.

I'll update the soon to be PR-ed quarkus-oidc-client with the quarkus-smallrye-jwt-build dependency asap after the merge as well - as I'll need to support the client credentials JWT authentication there (similarly to how quarkus-oidc does it).

Tests which depend on this API are run in quarkus-smallrye-jwt/deployment, integration-test/oidc-code-flow, integration-test/oidc-tenancy and in the quickstarts/security-jwt-quickstart

@ghost ghost added area/dependencies Pull requests that update a dependency file area/documentation area/oidc area/smallrye labels Dec 2, 2020
@sberyozkin sberyozkin requested review from gsmet and gastaldi December 2, 2020 13:41
@sberyozkin
Copy link
Member Author

I've tested the failing oidc integration tests with mvn clean install -Dnative forgetting it should be mvn clean install -Pdocker-keycloak -Ptest-keycloak -Dnative :-)

@sberyozkin
Copy link
Member Author

Hmm, all of these tests work for me in the native mode...

@sberyozkin sberyozkin force-pushed the quarkus-smallrye-jwt-build branch from 04a78fe to e2f9483 Compare December 2, 2020 16:14
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Contributor

gastaldi commented Dec 2, 2020

This extension kinda relates to https://github.com/quarkiverse/quarkiverse-jjwt-jackson that @gsmet created?

@sberyozkin
Copy link
Member Author

sberyozkin commented Dec 2, 2020

@gastaldi that extension is indeed related in that it may be able to do some parts of what the smallrye-jwt build extension can. But it is not part of the smallrye-jwt strategy.

@sberyozkin
Copy link
Member Author

I need to tweak the deployment package name a bit

@sberyozkin sberyozkin force-pushed the quarkus-smallrye-jwt-build branch from e2f9483 to 52d1b0c Compare December 2, 2020 21:13
@sberyozkin sberyozkin merged commit 643c66a into quarkusio:master Dec 3, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 3, 2020
@sberyozkin sberyozkin deleted the quarkus-smallrye-jwt-build branch December 3, 2020 10:35
@rsvoboda
Copy link
Member

rsvoboda commented Feb 3, 2021

@sberyozkin don't see any note about this in https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.11

You mentioned in the description: "I'll also update the migration notes for 11.0.0.Final that those quarkus-smallrye-jwt users who also require creating JWT tokens will need to add a quarkus-smallrye-jwt-build dependency"

@sberyozkin
Copy link
Member Author

@rsvoboda sorry, missed it, nothing escapes QE :-).
Have updated it now: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.11, please suggest some text modifications if you prefer, thanks

@sberyozkin
Copy link
Member Author

@rsvoboda Just tweaked the guide to remove the requirement for quarkus-smallrye-jwt users to depend on it :-) in view of #14803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add smallrye-jwt-build extension
3 participants