Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertx web client config #15192

Open
FroMage opened this issue Feb 19, 2021 · 7 comments
Open

Add vertx web client config #15192

FroMage opened this issue Feb 19, 2021 · 7 comments
Labels
area/vertx kind/enhancement New feature or request

Comments

@FroMage
Copy link
Member

FroMage commented Feb 19, 2021

We're using the vertx web client in RESTEasy Reactive, but there's no way to configure it. While we might add jaxrs-client-specific config to override global web client settings, there should be a way to configure the vertx web client globally, possibly in the vertx extension?

@FroMage FroMage added the kind/enhancement New feature or request label Feb 19, 2021
@FroMage
Copy link
Member Author

FroMage commented Feb 19, 2021

Related to #15189

@geoand
Copy link
Contributor

geoand commented Feb 22, 2021

Definitely +1 for this idea.

I don't see however how we could make these settings global as the HttpClient is created like so:

vertx.createHttpClient();

The WebClient is created in similar fashion:

WebClient.create(vertx)

Perhaps we need some new SPI in Vertx where we can register the default HttpClientOptions and WebClientOptions?

@cescoffier
Copy link
Member

At the moment the Vert.x Web Client is unmanaged.
Injected a managed one is tricky as configuration (host/port) are likely going to be different every time.

What about a facade like:

WebClient create(WebClientOptions options)

which would merge the options with some default ones and produce the web client?

@geoand
Copy link
Contributor

geoand commented Feb 22, 2021

Yeah, that's a good idea

@bmontuelle
Copy link

+1 for this, we need to enable logs in Vert.x Web client and it seems this requires passing WebClientOptions.setLogActivity to true for it to log requests and responses

@mkouba
Copy link
Contributor

mkouba commented Nov 14, 2022

Do I understand it correctly that Clement's proposal should end up in the quarkus-vertx-http extension?

@cescoffier
Copy link
Member

Yes, or in a new extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertx kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants