Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC - extensions should be able to specify artifacts that should be excluded from discovery #15713

Closed
mkouba opened this issue Mar 15, 2021 · 6 comments
Assignees
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented Mar 15, 2021

See also https://groups.google.com/g/quarkus-dev/c/5DGnNbZ9zdo.

We should introduce a new build item, e.g. ExcludeDependencyBuildItem (with groupdId, artifactId and optional classifier) and include these build items in the processing here: BeanArchiveProcessor#isApplicationArchiveExcluded().

@mkouba mkouba added the kind/enhancement New feature or request label Mar 15, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 15, 2021

/cc @manovotn

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Mar 15, 2021
@mkouba mkouba self-assigned this Mar 15, 2021
@masini
Copy link
Contributor

masini commented Mar 15, 2021

Hi Martin, I introduced the

public final class ExcludeDependencyBuildItem extends MultiBuildItem {
    private final String groupId;
    private final String artifactId;
    private final String classifier;

    public ExcludeDependencyBuildItem(String groupId, String artifactId) {
        this(groupId, artifactId, null);
    }
...
...

which is used inside private boolean isApplicationArchiveExcluded(ArcConfig config, ApplicationArchive archive) and then I tested inside the SmallRyeReactiveMessagingMqttProcessor and it works.

Do you think can be a good idea to create a PR ?

I modified two modules:

  • quarkus-core-deployment
  • quarkus-arc-deployment

@mkouba
Copy link
Contributor Author

mkouba commented Mar 16, 2021

Do you think can be a good idea to create a PR ?

Sure thing. Go ahead! :-)

@masini
Copy link
Contributor

masini commented Mar 16, 2021

Created the PR #15781, let me know

@mkouba mkouba added this to the 1.14 - main milestone Mar 25, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Mar 25, 2021

The PR was merged.

@mkouba mkouba closed this as completed Mar 25, 2021
@masini
Copy link
Contributor

masini commented Mar 25, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants