Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest Client Reactive - passing headers with async return type doesn't work #16577

Closed
michalszynkiewicz opened this issue Apr 16, 2021 · 3 comments · Fixed by #16581
Closed

Rest Client Reactive - passing headers with async return type doesn't work #16577

michalszynkiewicz opened this issue Apr 16, 2021 · 3 comments · Fixed by #16581
Assignees
@michalszynkiewicz
Labels
area/rest-client kind/bug Something isn't working
Milestone
1.13.3.Final

Comments

@michalszynkiewicz
Copy link
Member

with

    @GET
    EmployeeDto getByToken(@HeaderParam("MyHeader") String header);

passing MyHeader works but with the following, it doesn't:

    @GET
    Uni<EmployeeDto> getByToken(@HeaderParam("MyHeader") String header);
@michalszynkiewicz michalszynkiewicz added the kind/bug Something isn't working label Apr 16, 2021
@michalszynkiewicz michalszynkiewicz self-assigned this Apr 16, 2021
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Apr 16, 2021
@michalszynkiewicz
Rest Client Reactive - passing headers for async calls
aacd94d 
fixes quarkusio#16577
@michalszynkiewicz michalszynkiewicz mentioned this issue Apr 16, 2021
Merged
@spbolton
Copy link

I think this is related to a bug and pull request I have pushed to resteasy . The Parameter annotations are being ignored when using Uni https://issues.redhat.com/browse/RESTEASY-2872

@spbolton
Copy link

My issue was with the regular original REST client when using Uni not the new reactive client, not sure if this is still using the same code I fixed in the base Resteasy code.

@michalszynkiewicz
Copy link
Member Author

@spbolton thanks for adding a comment that might be useful :)
In this case, the underlying code is completely separate. The fix is awaiting review and should be in Quarkus 2.0 (who knows, maybe even next 1.3.x)

@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 23, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.3.Final Apr 26, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 26, 2021
@michalszynkiewicz @gsmet
Rest Client Reactive - passing headers for async calls
f1d890c 
fixes quarkusio#16577

(cherry picked from commit aacd94d)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 26, 2021
@michalszynkiewicz @gsmet
Rest Client Reactive - passing headers for async calls
f3e5c8c 
fixes quarkusio#16577

(cherry picked from commit aacd94d)
@gwenneg gwenneg mentioned this issue Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalszynkiewicz michalszynkiewicz

Labels
area/rest-client kind/bug Something isn't working
Projects
None yet
Milestone
1.13.3.Final
Development

Successfully merging a pull request may close this issue.

Rest Client Reactive - passing headers for async calls michalszynkiewicz/quarkus
3 participants
@spbolton @gsmet @michalszynkiewicz