-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce versions of ClientRequestFilter and ClientResponseFilter that can suspend and resume #16615
Comments
/cc @FroMage, @stuartwdouglas |
Well OK, but then also exception mappers, no? ;) |
Yup |
But probably later, cause I don't know if/how are handling the exception mapper for the client |
Sure, those are not linked. |
I opened a new issue: #16626 |
Damnit, man, I'm sorry I misread this issue. I thought you were talking about annotation-declared client requests and filters, and I suggested adding annotation-declared exception mappers. I didn't realise I had mis-read the subject. I don't think exception mappers can suspend on the server-side, can they? |
No need to apologize, you likely read the correct thing :) As for exception mappers, they can resume on server |
Hahahaha, excellent :) |
Huh, is that by design or because we forgot? |
I think it's just how the JAX-RS client works by spec - if it worked otherwise, the TCK would have a ton of failing tests :) |
Introduce the ability to create client filters that suspend and resume
OK, but is it what we think is the right thing to do? I mean, programmatically supporting them is one thing, and we do ATM. But why limit it this way? https://quarkus.io/specs/jaxrs/2.1/index.html#binding_in_client_api says:
So, IMO we can make a good case for supporting, in addition to the spec, globally registered client filters by adding |
Yeah, I like the idea. |
Description
In RESTEasy Reactive we have the
ResteasyReactiveContainerRequestFilter
andResteasyReactiveContainerResponseFilter
which can suspend and resume thus allowing for non-blocking filters.We should have something similar for the client
Originally came up in #16523
The text was updated successfully, but these errors were encountered: