Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC Dev UI support #17064

Closed
mkouba opened this issue May 7, 2021 · 5 comments
Closed

gRPC Dev UI support #17064

mkouba opened this issue May 7, 2021 · 5 comments
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone
2.0.0.CR2

Comments

@mkouba
Copy link
Contributor

mkouba commented May 7, 2021

It can be helpful to provide some basic Dev UI functionality for the gRPC extension, e.g.

  • List all @GrpcServices
  • Provide some basic way to test the services

We could either make use of an existing tool (such as grpcurl), probably started via DevServices, or try to implement some basic UI, e.g. reuse the generated stubs and com.google.protobuf.util.JsonFormat.
@mkouba mkouba added the kind/enhancement New feature or request label May 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

/cc @cescoffier, @michalszynkiewicz

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label May 7, 2021
@mkouba
Copy link
Contributor Author

mkouba commented May 24, 2021

The initial support was added in #17381.

@mkouba
Copy link
Contributor Author

mkouba commented Jun 2, 2021

@michalszynkiewicz I think that we can close this one. WDYT?

@cescoffier
Copy link
Member

I would say so, improvements can be added later.

@mkouba
Copy link
Contributor Author

mkouba commented Jun 3, 2021

Addressed in #17381, #17442 and follow-up bugfix PRs.

@mkouba mkouba closed this as completed Jun 3, 2021
@mkouba mkouba added this to the 2.0.0.CR2 milestone Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Milestone
2.0.0.CR2
Development

No branches or pull requests
2 participants
@cescoffier @mkouba