Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Dev UI - support streaming calls #17442

Merged

Conversation

michalszynkiewicz
Copy link
Member

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0ab176a

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs
Native Tests - gRPC Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.testUnaryMethodCall line 26 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

📦 extensions/websockets/deployment

io.quarkus.undertow.websockets.test.WebsocketDevModeTestCase.testWebsocketHotReplacement line 81 - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/grpc/deployment

io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.testUnaryMethodCall line 26 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub

📦 extensions/websockets/deployment

io.quarkus.undertow.websockets.test.WebsocketDevModeTestCase.testWebsocketHotReplacement line 81 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/grpc/deployment

io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.testUnaryMethodCall line 26 - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

📦 extensions/websockets/deployment

io.quarkus.undertow.websockets.test.WebsocketDevModeTestCase.testWebsocketHotReplacement line 81 - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 849 - More details - Source on GitHub


⚙️ Native Tests - gRPC #

📦 integration-tests/grpc-health

io.quarkus.grpc.health.MicroProfileHealthDisabledTest. - More details - Source on GitHub

io.quarkus.grpc.health.MicroProfileHealthEnabledTest. - More details - Source on GitHub

@mkouba
Copy link
Contributor

mkouba commented May 25, 2021

Looks good. For the streams we should probably prepend the last message to the output so that the user can see the last message without scrolling.

I've also noticed the following warning in the console when the stream is disconnected:

WARN  [io.qua.grp.run.dev.GrpcDevConsoleRecorder] (vert.x-eventloop-thread-7) failed to send back message to the gRPC Dev Console WebSocket: io.vertx.core.impl.NoStackTraceThrowable: WebSocket is closed

Finally, would it make sense to send a "cancellation" event if disconnected? E.g. for a Multi with infinite number of items...

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 849856e

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - HTTP Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc1 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc2 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc3 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc4 Build ⚠️ Check → Logs Raw logs
Native Tests - Security2 Build ⚠️ Check → Logs Raw logs
Native Tests - Spring Build ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 943b5f8

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 56be9b3

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
Native Tests - gRPC Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/grpc-health

io.quarkus.grpc.health.MicroProfileHealthDisabledTest. - More details - Source on GitHub

io.quarkus.grpc.health.MicroProfileHealthEnabledTest. - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 integration-tests/grpc-health

io.quarkus.grpc.health.MicroProfileHealthDisabledTest. - More details - Source on GitHub

io.quarkus.grpc.health.MicroProfileHealthEnabledTest. - More details - Source on GitHub


⚙️ Native Tests - gRPC #

📦 integration-tests/grpc-health

io.quarkus.grpc.health.MicroProfileHealthDisabledTest. - More details - Source on GitHub

io.quarkus.grpc.health.MicroProfileHealthEnabledTest. - More details - Source on GitHub

@michalszynkiewicz
Copy link
Member Author

Looks good. For the streams we should probably prepend the last message to the output so that the user can see the last message without scrolling.

also the default sizes of the "outputs" could be different. I'd rather leave it as it is for this PR though...

I've also noticed the following warning in the console when the stream is disconnected:

WARN  [io.qua.grp.run.dev.GrpcDevConsoleRecorder] (vert.x-eventloop-thread-7) failed to send back message to the gRPC Dev Console WebSocket: io.vertx.core.impl.NoStackTraceThrowable: WebSocket is closed

I didn't know what to do in this case, in this case it is expected, in others it may not be. I changed it to INFO now


Finally, would it make sense to send a "cancellation" event if disconnected? E.g. for a `Multi` with infinite number of items...

Done, I think ;)

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 56be9b3

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Devtools Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Devtools Tests - JDK 11 Windows Set up JDK 11 ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Reclaim Disk Space ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Extract Maven Repo ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Set up JDK 11 ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Set up JDK 11 ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Amazon ⚠️ Check → Logs Raw logs
Native Tests - Cache ⚠️ Check → Logs Raw logs
Native Tests - Data1 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data2 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data3 Build ⚠️ Check → Logs Raw logs
Native Tests - Data4 Build ⚠️ Check → Logs Raw logs
Native Tests - Data5 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Data6 Set up JDK 11 ⚠️ Check → Logs Raw logs
Native Tests - Data7 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - HTTP ⚠️ Check → Logs Raw logs
Native Tests - Main Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 ⚠️ Check → Logs Raw logs
Native Tests - Misc1 ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 ⚠️ Check → Logs Raw logs
Native Tests - Security2 ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 3666102

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Devtools Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Devtools Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Amazon Build ⚠️ Check → Logs Raw logs
Native Tests - Cache ⚠️ Check → Logs Raw logs
Native Tests - Data1 Build ⚠️ Check → Logs Raw logs
Native Tests - Data2 Build ⚠️ Check → Logs Raw logs
Native Tests - Data3 Build ⚠️ Check → Logs Raw logs
Native Tests - Data4 Build ⚠️ Check → Logs Raw logs
Native Tests - Data5 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Data6 Build ⚠️ Check → Logs Raw logs
Native Tests - Data7 Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP ⚠️ Check → Logs Raw logs
Native Tests - Main Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 ⚠️ Check → Logs Raw logs
Native Tests - Misc1 ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 ⚠️ Check → Logs Raw logs
Native Tests - Security2 ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 0b2aa95

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Tar Maven Repo ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 25, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ed0fcb3

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
Native Tests - Data7 Download Maven Repo ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.websocketTest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 70 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/grpc/deployment

io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.websocketTest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub

@michalszynkiewicz michalszynkiewicz force-pushed the grpc-devui-streams branch 2 times, most recently from 1991ff6 to 66d4a9c Compare May 26, 2021 09:43
@quarkus-bot
Copy link

quarkus-bot bot commented May 26, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 1991ff6

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 16 Build ⚠️ Check → Logs Raw logs
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Amazon Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Cache ⚠️ Check → Logs Raw logs
Native Tests - Data1 Build ⚠️ Check → Logs Raw logs
Native Tests - Data4 Build ⚠️ Check → Logs Raw logs
Native Tests - Data7 Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Misc1 ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Security2 Reclaim Disk Space ⚠️ Check → Logs Raw logs
Native Tests - Security3 ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 26, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 66d4a9c

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadAfterRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testSingleReload - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testInterceptorReload - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testReloadBeforeRest - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 26, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9206862

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16
Native Tests - gRPC Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/grpc-streaming

io.quarkus.grpc.example.streaming.StreamingEndpointTest.testPipe line 30 - More details - Source on GitHub


⚙️ Native Tests - gRPC #

📦 integration-tests/grpc-streaming

io.quarkus.grpc.example.streaming.StreamingEndpointTest.testPipe line 30 - More details - Source on GitHub

@michalszynkiewicz michalszynkiewicz force-pushed the grpc-devui-streams branch 2 times, most recently from 7b0d8b6 to 3851067 Compare May 31, 2021 08:01
@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 7b0d8b6

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 3851067

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
JVM Tests - JDK 16 Build Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs
Native Tests - Cache Build ⚠️ Check → Logs Raw logs
Native Tests - HTTP Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging1 Build ⚠️ Check → Logs Raw logs
Native Tests - Messaging2 Build ⚠️ Check → Logs Raw logs
Native Tests - Misc1 Extract Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - Misc2 ⚠️ Check → Logs Raw logs
Native Tests - Misc3 ⚠️ Check → Logs Raw logs
Native Tests - Misc4 ⚠️ Check → Logs Raw logs
Native Tests - Security1 Build ⚠️ Check → Logs Raw logs
Native Tests - Security2 Build ⚠️ Check → Logs Raw logs
Native Tests - Security3 Build ⚠️ Check → Logs Raw logs
Native Tests - Spring ⚠️ Check → Logs Raw logs
Native Tests - Windows - hibernate-validator ⚠️ Check → Logs Raw logs
Native Tests - gRPC ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun line 70 - More details - Source on GitHub


⚙️ JVM Tests - JDK 16 #

📦 extensions/vertx-http/deployment

io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode line 41 - More details - Source on GitHub

io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun line 48 - More details - Source on GitHub

@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2021

Failing Jobs - Building 4c81250

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

@michalszynkiewicz michalszynkiewicz merged commit 0bc477f into quarkusio:main May 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone May 31, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final May 31, 2021
@mkouba mkouba mentioned this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants