-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Dev UI - support streaming calls #17442
gRPC Dev UI - support streaming calls #17442
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0ab176a
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ 📦 extensions/websockets/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/grpc/deployment✖ ✖ ✖ 📦 extensions/websockets/deployment✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖ ✖ 📦 extensions/websockets/deployment✖ ⚙️ Maven Tests - JDK 11 #📦 integration-tests/maven✖ ⚙️ Native Tests - gRPC #📦 integration-tests/grpc-health✖ ✖ |
0ab176a
to
849856e
Compare
extensions/grpc/deployment/src/main/resources/dev-templates/service.html
Outdated
Show resolved
Hide resolved
Looks good. For the streams we should probably prepend the last message to the output so that the user can see the last message without scrolling. I've also noticed the following warning in the console when the stream is disconnected:
Finally, would it make sense to send a "cancellation" event if disconnected? E.g. for a |
849856e
to
943b5f8
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 849856e
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖ |
943b5f8
to
56be9b3
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 56be9b3
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/grpc-health✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/grpc/deployment✖ ⚙️ JVM Tests - JDK 16 #📦 integration-tests/grpc-health✖ ✖ ⚙️ Native Tests - gRPC #📦 integration-tests/grpc-health✖ ✖ |
56be9b3
to
c1ff212
Compare
also the default sizes of the "outputs" could be different. I'd rather leave it as it is for this PR though...
I didn't know what to do in this case, in this case it is expected, in others it may not be. I changed it to INFO now
Done, I think ;) |
c1ff212
to
3666102
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 56be9b3
|
3666102
to
0b2aa95
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 3666102
|
0b2aa95
to
ed0fcb3
Compare
This workflow status is outdated as a new workflow run has been triggered. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building ed0fcb3
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖ ✖ ✖ |
1991ff6
to
66d4a9c
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 1991ff6
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 66d4a9c
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/grpc/deployment✖ ✖ ✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/grpc/deployment✖ |
66d4a9c
to
9206862
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 9206862
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/grpc-streaming✖ ⚙️ Native Tests - gRPC #📦 integration-tests/grpc-streaming✖ |
7b0d8b6
to
3851067
Compare
This workflow status is outdated as a new workflow run has been triggered. |
3851067
to
4c81250
Compare
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 3851067
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 extensions/vertx-http/deployment✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ ✖ |
No description provided.