Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable xstream based tests on JDK 16+ #17091

Closed
famod opened this issue May 8, 2021 · 7 comments · Fixed by #17097
Closed

Enable xstream based tests on JDK 16+ #17091

famod opened this issue May 8, 2021 · 7 comments · Fixed by #17097
Assignees
@famod
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/testing
Milestone
2.0.0.Alpha3

Comments

@famod
Copy link
Member

famod commented May 8, 2021 •
edited
Loading

Update to a xstream version that fixes the illegal access problems and revert 7d4bec1 (⚠️ surefire.argLine.additional should stay!).

Relates to #16195.

  • set JDK 16 (e.g. via sdk)
  • if Kotlin 1.5 is not yet integrated: add --add-opens java.base/java.util=ALL-UNNAMED to MAVEN_OPTS
  • mvn -Dquickly -T1C
  • mvn clean verify -f integration-tests/main (should not fail)
  • mvn clean verify -f integration-tests/main -P'!jdk16-workarounds' (should fail)
@famod famod added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/testing labels May 8, 2021
@famod famod self-assigned this May 8, 2021
@famod
Copy link
Member Author

famod commented May 8, 2021

I'll have a look at whether this still happens with xstream master (which means 1.5 will fix it).

@famod
Copy link
Member Author

famod commented May 9, 2021

This unfortunately still fails with xstream 1.5.0-SNAPSHOT: x-stream/xstream#253

/cc @geoand

@famod famod removed their assignment May 9, 2021
@famod famod mentioned this issue May 9, 2021
Closed
@geoand
Copy link
Contributor

geoand commented May 9, 2021

😢

@famod
Copy link
Member Author

famod commented May 9, 2021

Ok, I found some workarounds: x-stream/xstream#253 (comment)

Will send a PR to re-enable the tests on Java 16. But this won't help users of Quarkus, I'm afraid.

@famod famod self-assigned this May 9, 2021
@famod famod mentioned this issue May 9, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 9, 2021
@famod
Copy link
Member Author

famod commented May 11, 2021

@geoand @stuartwdouglas I'm not that familiar with the classloading in Quarkus. The xstream maintainer is assuming that "You run XStream in the ModulePath": x-stream/xstream#253 (comment)
Does that ring a bell?

@geoand
Copy link
Contributor

geoand commented May 11, 2021

We do not do anything with the module path, it's all classpath

@famod
Copy link
Member Author

famod commented May 11, 2021

Ok, that's what I was suspecting. Thanks for confiming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@famod famod

Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/testing
Projects
None yet
Milestone
2.0.0.Alpha3
Development

Successfully merging a pull request may close this issue.

Work around xstream issues in main ITs on Java 16
2 participants
@geoand @famod