-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: replace JDK 15 with 16 #16195
Comments
/cc @evanchooly |
I'm currently testing some fixes/workarounds for the known problems: |
After skipping |
Affected test classes with number of failing test methods:
updated on 02.05.2021 |
All those I think I'll create an issue for Surefire. But we probably can't wait for a release with a fix (if any such fix is even possible in the first place).
FYI @Tibor17. What's interesting is that Surefire is also setting |
Two tests in
Will have to set |
Various tests fail in
Will have to set --add-opens here as well. |
We already do that in https://github.com/jboss/jboss-parent-pom/blob/main/pom.xml#L587. Maybe that's not being used correctly? |
Thanks for checking, but turns out it has to be set via |
Ah! So it's not actually Surefire setting it on its own! That's good to know. So, sorry for bothering you @Tibor17! |
Is that because of JDK 16+ only? I remember this setting working in other projects just fine. |
Yes, JDK16+ only as far I could trace it back: openjdk/jdk@6bb7e45#diff-64e57a650df91c988910dd64b53c82b0521869c5f4afd1024f03c6a97f3a8344 |
I've updated the TODO list to reflect the current state of affairs. Two builds are running currently in my fork, will check them in the next few days. |
@famod |
@famod |
@Tibor17 WDYT about extending the Btw @gastaldi I'm now getting:
So I'll have to override the property from PS: Meh...I guess IntelliJ IDEA will then also use the default temp dir for testing. |
@Ladicek @jmartisk @michalszynkiewicz
Is this a known problem? Is there a fix? |
@famod
it is a parameterized message and Regarding |
@famod It is a known problem now that you pointed it to me :-) I'll take a look, thanks. |
Current state (rest is ok):
|
@famod |
Regarding
Quoting from Surefire code, the system properties are the Maven system properties and config parameters |
It's clear where it's coming from: <systemPropertyVariables combine.self="override"> Btw, I think I'll create a SUREFIRE issue in the next few days for the suggestion to handle certain |
@famod |
@Tibor17 Interesting! But that's kind of funny because those are deprecated and not long ago I changed it in |
@famod |
Funny thing is that once I updated Weld in SmallRye Fault Tolerance (to the latest release that supports JDK 16), all tests pass, including the entire TCK. Which suggests there may be something wrong in Quarkus. Hmm. |
Ah, I know what's wrong. EDIT: the |
Should be fixed in next SmallRye Fault Tolerance release that will contain smallrye/smallrye-fault-tolerance#409 |
@Ladicek Great, thanks! Will exclude the affected tests until then. |
Description
JDK 16 reached GA a few weeks ago and the natural cycle would be to replace the jobs in Quarkus CI that are currently running on JDK 15 with JDK 16.
Our EA test job/workflow [1] is still running on 16 (and not 17-ea) because there are still some problems, especially with Kotlin and Gradle.
The idea is to get the EA job to the point where we can make the switch (both for CI JDK 15 -> 16 and EA job 16 -> 17-ea).
[1] https://github.com/quarkusio/quarkus/actions/workflows/jdk-early-access-build.yml (see also #15867)
FTR:
/cc @gsmet @gastaldi
Currently known TODOs (potentially incomplete)
Illegal reflective access by com.intellij.util.ReflectionUtil to method java.util.ResourceBundle.setParent(java.util.ResourceBundle)
--add-opens java.base/java.util=ALL-UNNAMED
viaMAVEN_OPTS
BootstrapMavenOptions
from passing--add-opens
etc. to MavenCliManager
(which chokes on that), see also Error during build: Unrecognized option: --add-opens #16862note: complete HACK currently (in my fork), must be done properly
devtools/gradle
andits/gradle
devtools/cli
testsjava.io.tmpdir
problem: CI: replace JDK 15 with 16 #16195 (comment)For now checked TODOs can be found in my fork: main...famod:jdk16-fixes
The text was updated successfully, but these errors were encountered: