Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TCKS rest-client tests on JDK 16+ #17093

Closed
famod opened this issue May 8, 2021 · 8 comments · Fixed by #19559
Closed

Enable TCKS rest-client tests on JDK 16+ #17093

famod opened this issue May 8, 2021 · 8 comments · Fixed by #19559
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/rest-client
Milestone
2.3.0.CR1

Comments

@famod
Copy link
Member

famod commented May 8, 2021 •
edited by gsmet
Loading

Analyze problem (illegal access w.r.t. "opens java.lang.invoke" and also plain assertion errors), probably update some component and revert 6f62740.

Relates to #16195.

  • set JDK 16 (e.g. via sdk)
  • mvn -Dquickly -T1C
  • mvn clean verify -f tcks/microprofile-rest-client (should not fail)
  • mvn clean verify -f tcks/microprofile-rest-client -P'!jdk16-workarounds' (should fail)
@famod famod added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label May 8, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 8, 2021

/cc @michalszynkiewicz

@famod
Copy link
Member Author

famod commented Jun 17, 2021

Will most likely require an upgrade to RESTEasy 4.7.0: https://issues.redhat.com/browse/RESTEASY-2905

@famod
Copy link
Member Author

famod commented Jul 12, 2021

Quarkus issue for the update: #18622

@famod famod self-assigned this Jul 14, 2021
@famod famod mentioned this issue Jul 19, 2021
Merged
@famod famod removed their assignment Jul 19, 2021
@famod
Copy link
Member Author

famod commented Jul 19, 2021

Timeout*Tests still fail, see #18710 (comment)

@famod famod mentioned this issue Aug 20, 2021
Merged
@gsmet
Copy link
Member

gsmet commented Aug 20, 2021

@michalszynkiewicz any chance you could have a look at this one when you have some time? It would be nice to have everything working with JDK 16+

@michalszynkiewicz
Copy link
Member

If nothing more urgent pops up, I'll take a look at it on Monday

@jaikiran jaikiran mentioned this issue Aug 21, 2021
Merged
@jaikiran
Copy link
Member

Hello @michalszynkiewicz, @gsmet, this PR #19559 should fix the Timeout* test case failures in Java 16+.

@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 23, 2021
@michalszynkiewicz
Copy link
Member

thanks for handling this @jaikiran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/rest-client
Projects
None yet
Milestone
2.3.0.CR1
Development

Successfully merging a pull request may close this issue.

Re-enable remaining excluded Timeout* tests in microprofile-rest-client TCK for Java 16+
4 participants
@jaikiran @gsmet @michalszynkiewicz @famod