-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the use of Mandrel images easier #18129
Comments
/cc @galderz |
Hmmm, I think I'd leave
|
Although I like how this separates the actual image from the distribution/provider I am afraid it might make things unnecessarily complicated. E.g. , users might think they need to pass I think I like more the option of making |
That sounds like an interesting idea, I like it! |
I think that's a fair suggestion. I would suggest validating the contents of the property early on so that any mistakes are clearly reported. So, it's either one of the 2 (currently) reserved words, or a URL. |
…age` This change makes it easier for developers to choose the variant of the builder image they want to use without having to worry about which version is the currently supported one. Quarkus will figure that out on their behalf. Closes quarkusio#18129
…age` This change makes it easier for developers to choose the variant of the builder image they want to use without having to worry about which version is the currently supported one. Quarkus will figure that out on their behalf. Closes quarkusio#18129
…age` This change makes it easier for developers to choose the variant of the builder image they want to use without having to worry about which version is the currently supported one. Quarkus will figure that out on their behalf. Closes quarkusio#18129
Description
Currently Quarkus defaults to using
native-image
from$GRAALVM_HOME/bin
,$JAVA_HOME/bin
, or the system's$PATH
. Ifnative-image
is not available then it falls back to using a container runtime with the ubi-quarkus-native-image container image.The main benefit of this is that users can simply run:
and create a native executable of their Quarkus application without any local setup. This also makes it easy to ensure that the users are using the correct container image (and the correct version) since it's defined in
build-parent/pom.xml
In order for users to use Mandrel they need to do one of the following:
native-image
can be found either in$GRAALVM_HOME/bin
,$JAVA_HOME/bin
, or the system's$PATH
.-Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-mandrel:21.0-java11
Now the issue I see with both options is that the user is responsible for figuring out the correct Mandrel version to use.
I believe that Quarkus should offer an option to allow users to state that they would like to build their native executable using Mandrel without the need to worry about the correct version.
e.g.
Implementation ideas
We could possibly introduce yet another property like
quarkus.native.mandrel
or we could handle something like-Dquarkus.native.builder-image=mandrel
and replacemandrel
with theubi-quarkus-mandrel
image that is compatible with the Quarkus version being used.WDYT?
The text was updated successfully, but these errors were encountered: