Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus.kubernetes-config.secrets.enabled not explained on Kubernetes Config documentation #18963

Closed
languitar opened this issue Jul 23, 2021 · 9 comments · Fixed by #18969
Closed

Comments

@languitar
Copy link
Contributor

Describe the bug

The configuration reference for kubernetes config does not list the property quarkus.kubernetes-config.secrets.enabled

Expected behavior

Should be included in the property list on that page

Actual behavior

Only mention in the explanations of another property

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@languitar languitar added the kind/bug Something isn't working label Jul 23, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 23, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Jul 23, 2021

cc @metacosm

EDIT: I had not read the issue properly

@machi1990
Copy link
Member

@machi1990 machi1990 self-assigned this Jul 23, 2021
@geoand
Copy link
Contributor

geoand commented Jul 23, 2021

Thanks!

@machi1990
Copy link
Member

Thanks!

I had a first look at there are couple of reasons for this:

  • we are only including a partial configuration (quarkus-kubernetes-config-kubernetes-config-source-config.adoc) for the extension (BOOTSTRAP config root from the KubernetesConfigSourceConfig.java file). The one we are interested with is at: quarkus-kubernetes-config-kubernetes-config-build-time-config.adoc (also a partial generated output)
  • there is a bug in sense that the quarkus-kubernetes-config.adoc file should be generated too along side the partial configuration but this is not the case. But a quarkus-kubernetes-client.adoc file is generated for the module.
  • There is another bug related to the one above in https://quarkus.io/guides/kubernetes-client#quarkus-kubernetes-client_quarkus.kubernetes-config.secrets.enabled because now the kubernetes-client configuration contains kubernetes-config. Not sure if this is a bug or an intended behaviour at this stage.

I'll investigate more on this if it impact other area and look into a fix.

@machi1990
Copy link
Member

Thanks!

I had a first look at there are couple of reasons for this:

  • we are only including a partial configuration (quarkus-kubernetes-config-kubernetes-config-source-config.adoc) for the extension (BOOTSTRAP config root from the KubernetesConfigSourceConfig.java file). The one we are interested with is at: quarkus-kubernetes-config-kubernetes-config-build-time-config.adoc (also a partial generated output)
  • there is a bug in sense that the quarkus-kubernetes-config.adoc file should be generated too along side the partial configuration but this is not the case. But a quarkus-kubernetes-client.adoc file is generated for the module.
  • There is another bug related to the one above in https://quarkus.io/guides/kubernetes-client#quarkus-kubernetes-client_quarkus.kubernetes-config.secrets.enabled because now the kubernetes-client configuration contains kubernetes-config. Not sure if this is a bug or an intended behaviour at this stage.

I'll investigate more on this if it impact other area and look into a fix.

@geoand I might have found the issue, the package name is io.quarkus.kubernetes.client.runtime for the https://github.com/quarkusio/quarkus/tree/main/extensions/kubernetes-config/runtime module. See https://github.com/quarkusio/quarkus/blob/main/extensions/kubernetes-config/runtime/src/main/java/io/quarkus/kubernetes/client/runtime/KubernetesConfigSourceConfig.java#L1 Since the name is derived from it, the causes some issues. Not sure if that's indeed given that the deployment package is correctly named https://github.com/quarkusio/quarkus/blob/main/extensions/kubernetes-config/deployment/src/main/java/io/quarkus/kubernetes/config/deployment/KubernetesConfigProcessor.java#L1 ?

@geoand
Copy link
Contributor

geoand commented Jul 23, 2021

Ouch... That is likely just my dumb mistake in naming the package

@machi1990
Copy link
Member

Ouch... That is likely just my dumb mistake in naming the package

Okay, I'll prepare a PR to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants