Live reload instrumentation steps executed when instrumentation is disabled

[jamesnetherton]

Describe the bug

Raised off the back of this Zulip thread:

https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Live.20reload.20with.20instrumentation.20disabled

When quarkus.live-reload.instrumentation = false, it seems that intrumentation logic still runs.

Expected behavior

Instrumentation steps are not run on live reload if it's disabled.

Actual behavior

Instrumentation steps seem to be run on live reload if when they should be disabled.

How to Reproduce?

git clone https://github.com/apache/camel-quarkus-examples
cd timer-log
mvn quarkus:dev

Edit src/main/java/org/acme/timer/TimerRoute.java and change the log message to trigger a live reload. There's an exception due to a bug / bad implementation of the Camel HotReplacementSetup, but the message logged with the stack trace says Failed to replace classes via instrumentation. Which is unexpected if instrumentation is disabled.

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.2.3.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response