quarkus:dev hot reload behavior changed & UI resources not being loaded (new in 2.4.0.Final, works in 2.3.1.Final)

[nastra]

Describe the bug

We're hitting Hot reloadable dependency xyz has not been compiled yet... after upgrading to 2.4.0.Final. I think the issue is happening because of this line: https://github.com/quarkusio/quarkus/pull/20500/files#diff-dbfecb8ead57f5ad197c876b824b224ea62a3711ba4a3d2c0bb07da027aa11d1R708

Previously it was doing this via localProject.getSourcesDir().toAbsolutePath() but now it is checking module.getMainResources().iterator().next().getDestinationDir().toPath().toAbsolutePath(). Since our META-INF/resources directory is basically pointing to the build dir as defined in https://github.com/projectnessie/nessie/blob/1d9e32e47c573f9c0906a264f83066f6a45dde03/ui/pom.xml#L33-L39 the actual META-INF/resources directory doesn't exist under target, thus quarkus:dev complains.

With the changes from projectnessie/nessie#2475 we can overcome the hot reloadable... issue and make quarkus:dev start, but now static UI resources are not being loaded anymore when navigating to http://localhost:19120/, even though they are located under META-INF/resources (note that our UI resources are located in a separate maven module).

Expected behavior

static UI resources located under META-INF/resources should be loaded when running quarkus:dev

Actual behavior

static UI resources located under META-INF/resources are not loaded when running quarkus:dev

How to Reproduce?

1. git clone [email protected]:projectnessie/nessie.git
2. ./mvnw clean install quarkus:dev -DskipTests
3. optionally: apply the changes from Fix running quarkus:dev projectnessie/nessie#2475 to overcome the hot reloadable... issue
4. navigating to http://localhost:19120/ shows the UI with 2.3.1.Final, but fails with 2.4.0.Final

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[nastra]

/cc @aloubyansky since you worked on #20500, any chance you could take a look at this?

[aloubyansky]

@nastra thanks reporting. Apparently we had a bug in previous versions which didn't manifest itself before. #20986 fixes it.

[nastra]

@aloubyansky thanks for looking into that. I can confirm that #20986 fixes the first issue I mentioned with resource detection (we don't see the hot reloadable xyz resource issue anymore).
However, those static resources don't seem to be loaded anymore, even though they are at the right place (this is the second issue I mentioned in the problem description above). Could that be related to the changes from #20500 as well?

[aloubyansky]

Thanks for checking @nastra I'll have a look.

[aloubyansky]

Should be good now.

[dimas-b]

@aloubyansky : Good on main? :) Could you link a PR that fixed the problem, pls?

[aloubyansky]

I pushed the other fix to the same branch #20986

[nastra]

@aloubyansky I can confirm everything works again. Thanks for fixing

[aloubyansky]

Great, thanks for the confirmation!