Fix running quarkus:dev #2475
Closed
Fix running quarkus:dev #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since quarkus 2.4.0.Final quarkus:dev expects the META-INF/resources folder under target. The issue is happening because of this line: https://github.com/quarkusio/quarkus/pull/20500/files#diff-dbfecb8ead57f5ad197c876b824b224ea62a3711ba4a3d2c0bb07da027aa11d1R708 Previously it was doing this via `localProject.getSourcesDir().toAbsolutePath()` but now it is checking `module.getMainResources().iterator().next().getDestinationDir().toPath().toAbsolutePath()`. Since our `META-INF/resources` directory is basically pointing to the `build` dir as defined in https://github.com/projectnessie/nessie/blob/1d9e32e47c573f9c0906a264f83066f6a45dde03/ui/pom.xml#L33-L39 the actual `META-INF/resources` directory doesn't exist under `target`, thus `quarkus:dev` complains
dimas-b
approved these changes
Oct 22, 2021
Comment on lines
+201
to
+205
| <resource> | ||
| <targetPath>META-INF/resources</targetPath> | ||
| <directory>build</directory> | ||
| <filtering>false</filtering> | ||
| </resource> |
There was a problem hiding this comment.
Do we have to specify sources? Would it not use the default sources automatically?
Codecov Report
@@ Coverage Diff @@
## main #2475 +/- ##
============================================
+ Coverage 84.17% 84.19% +0.02%
- Complexity 1915 1916 +1
============================================
Files 251 251
Lines 10772 10772
Branches 764 764
============================================
+ Hits 9067 9070 +3
+ Misses 1400 1397 -3
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -185,6 +185,29 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <!-- since quarkus 2.4.0.Final quarkus:dev expects the META-INF/resources folder under target --> | |||
| <plugin> | |||
There was a problem hiding this comment.
other modules also don't have this config right ? how it is working ?
omarsmak
approved these changes
Oct 25, 2021
|
It looks like the |
This was referenced Oct 25, 2021
|
Will be fixed by quarkusio/quarkus#20974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since quarkus 2.4.0.Final quarkus:dev expects the META-INF/resources
folder under target.
The issue is happening because of this line: https://github.com/quarkusio/quarkus/pull/20500/files#diff-dbfecb8ead57f5ad197c876b824b224ea62a3711ba4a3d2c0bb07da027aa11d1R708
Previously it was doing this via
localProject.getSourcesDir().toAbsolutePath()but now it is checkingmodule.getMainResources().iterator().next().getDestinationDir().toPath().toAbsolutePath().Since our
META-INF/resourcesdirectory is basically pointing to thebuilddir as defined innessie/ui/pom.xml
Lines 33 to 39 in 1d9e32e
META-INF/resourcesdirectory doesn't exist undertarget, thusquarkus:devcomplains