Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension author guide: explain how to deal with META-INF/services files #2299

Closed
FroMage opened this issue Apr 30, 2019 · 3 comments
Closed
Labels
area/core area/documentation kind/enhancement New feature or request pinned Issue will never be marked as stale
Milestone

Comments

@FroMage
Copy link
Member

FroMage commented Apr 30, 2019

https://quarkus.io/guides/extension-authors-guide#register-resources-for-use-in-native-image led me to believe I only needed to register the file, but actually I need to call ServiceUtil to register the contents of the file for reflection, at the very least.

@gsmet gsmet added the pinned Issue will never be marked as stale label Nov 13, 2019
@gsmet
Copy link
Member

gsmet commented Nov 13, 2019

@FroMage care to provide a PR? It would be nice to close all these issues that are fixable in one hour instead of having them piling up.

Thanks.

@Sanne Sanne closed this as completed in 7c45ed8 Nov 14, 2019
Sanne added a commit that referenced this issue Nov 14, 2019
Fix #2299: mention service files in extension guide
@gsmet gsmet added this to the 1.1.0 milestone Nov 14, 2019
jmartisk pushed a commit to jmartisk/quarkus that referenced this issue Nov 15, 2019
@FroMage
Copy link
Member Author

FroMage commented Nov 18, 2019

It would be nice to close all these issues that are fixable in one hour instead of having them piling up.

Famous Last Words: it's been days and no resolution in sight :(

FroMage added a commit to FroMage/quarkus that referenced this issue Nov 19, 2019
@FroMage
Copy link
Member Author

FroMage commented Nov 19, 2019

Follow up at #5582

gsmet pushed a commit to FroMage/quarkus that referenced this issue Nov 19, 2019
ia3andy pushed a commit to dmlloyd/quarkus that referenced this issue Nov 19, 2019
gsmet added a commit that referenced this issue Nov 19, 2019
Second batch of modifications for #2299
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 19, 2019
Simulant87 pushed a commit to Simulant87/quarkus that referenced this issue Nov 23, 2019
Simulant87 pushed a commit to Simulant87/quarkus that referenced this issue Nov 23, 2019
mmusgrov pushed a commit to mmusgrov/quarkus that referenced this issue Dec 13, 2019
mmusgrov pushed a commit to mmusgrov/quarkus that referenced this issue Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/documentation kind/enhancement New feature or request pinned Issue will never be marked as stale
Projects
None yet
Development

No branches or pull requests

2 participants