Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a hibernate reactive variant of the security JPA extension #23553

Closed
mkouba opened this issue Feb 9, 2022 · 6 comments · Fixed by #32512
Closed

Introduce a hibernate reactive variant of the security JPA extension #23553

mkouba opened this issue Feb 9, 2022 · 6 comments · Fixed by #32512
Labels
area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE area/security kind/enhancement New feature or request
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented Feb 9, 2022

Description

The quarkus-security-jpa extension depends on quarkus-hibernate-orm so it would have to live in a separate extension. However, the @Username, @Password and @Roles annotations could be shared.

Implementation ideas

No response

@mkouba mkouba added the kind/enhancement New feature or request label Feb 9, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 9, 2022

/cc @DavideD, @Sanne, @gavinking, @sberyozkin

@quarkus-bot quarkus-bot bot added area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE area/security labels Feb 9, 2022
@sberyozkin
Copy link
Member

+1, then I can rebuild #22457 around it, as it was of some concern to @stuartwdouglas that security-jpa was not reactive

@geoand
Copy link
Contributor

geoand commented Feb 10, 2022

Definitely +1 for this

@Sanne
Copy link
Member

Sanne commented Feb 10, 2022

+1

from a usability point of view, it would be nice if it could switch internal implementation automatically, based on the bound datasource being blocking or reactive.

@SetoKaiba
Copy link
Contributor

Any update on it? We still can't use it with reactive?

@egore
Copy link

egore commented Jan 29, 2023

I started working on this a couple of days ago at https://github.com/egore/quarkus-security-jpa-reactive, as a copy&modify approach. Unfortunately I am currently stuck at the QuarkusSecurityJpaProcessor, which still creates the dynamic class using the EntityManager instead of a mutiny session. I think I can steal a good portion from the UserEntityIdentityProvider, but there I had to work around the lack of bySimpleNaturalId of Mutiny.Session.

michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 9, 2023
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 9, 2023
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 9, 2023
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 10, 2023
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 10, 2023
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 11, 2023
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Apr 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 13, 2023
cescoffier pushed a commit to cescoffier/quarkus that referenced this issue Apr 18, 2023
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE area/security kind/enhancement New feature or request
Projects
None yet
6 participants