Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict between micrometer and stork #23623

Closed
vsevel opened this issue Feb 11, 2022 · 8 comments · Fixed by #23741
Closed

conflict between micrometer and stork #23623

vsevel opened this issue Feb 11, 2022 · 8 comments · Fixed by #23741
Assignees
Labels
area/metrics kind/bug Something isn't working
Milestone

Comments

@vsevel
Copy link
Contributor

vsevel commented Feb 11, 2022

Describe the bug

When I add in the same application the stork extension and the micrometer extension I get an error.

Expected behavior

Should not conflict with each other.

Actual behavior

When I build the application I get:

[INFO] Running org.acme.ReactiveGreetingResourceTest
2022-02-11 18:56:35,295 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.273 s <<< FAILURE! - in org.acme.ReactiveGreetingResourceTest
[ERROR] org.acme.ReactiveGreetingResourceTest.testHelloEndpoint  Time elapsed: 0.007 s  <<< ERROR!
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
Caused by: java.lang.RuntimeException: Failed to start quarkus
Caused by: javax.enterprise.inject.CreationException: 
Synthetic bean instance for io.quarkus.micrometer.runtime.binder.HttpBinderConfiguration not initialized yet: io_quarkus_micrometer_runtime_binder_HttpBinderConfiguration_97d170e1550eee4afc0af065b78cda302a97674c
        - a synthetic bean initialized during RUNTIME_INIT must not be accessed during STATIC_INIT
        - RUNTIME_INIT build steps that require access to synthetic beans initialized during RUNTIME_INIT should consume the SyntheticBeansRuntimeInitBuildItem

How to Reproduce?

Get https://github.com/vsevel/stork-issue/tree/micrometer_stork_conflict

mvn clean package

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.7.1

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@vsevel vsevel added the kind/bug Something isn't working label Feb 11, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 11, 2022

/cc @ebullient

@vsevel
Copy link
Contributor Author

vsevel commented Feb 11, 2022

/cc @michalszynkiewicz

@michalszynkiewicz
Copy link
Member

@vsevel could you check if removing the client from the MyServiceDiscovery makes the error disappear?

@vsevel
Copy link
Contributor Author

vsevel commented Feb 11, 2022

@michalszynkiewicz
you are correct. it works with this vsevel/stork-issue@bd550b6

@ebullient
Copy link
Member

Is that a case of the discovery client making outbound http requests (that should in theory be measured) before things have been initialized?

@vsevel
Copy link
Contributor Author

vsevel commented Feb 12, 2022

I do not think it is about making the calls (it works when I lazy init the proxies), rather than trying to initialize the rest proxy too early.

@michalszynkiewicz
Copy link
Member

Haven't started looking at it yet but it seems to that stork initialization happens to early

@ebullient
Copy link
Member

Not sure if there is anything the micrometer initialization should change...

michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Feb 15, 2022
@michalszynkiewicz michalszynkiewicz self-assigned this Feb 15, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 16, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants