Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload with context propagation/quarkus-smallrye-reactive-messaging-kafka fails #2618

Closed
michalszynkiewicz opened this issue May 28, 2019 · 0 comments · Fixed by #2619
Closed
Labels
kind/bug Something isn't working
Milestone

Comments

@michalszynkiewicz
Copy link
Member

michalszynkiewicz commented May 28, 2019

Describe the bug
After a reload, an application that uses quarkus-smallrye-reactive-messaging-kafka fails with
https://gist.github.com/michalszynkiewicz/c71dba7a6f3d10b54adc3b2e2406a603

Expected behavior
The application should be reloaded

Actual behavior
An app that uses smallrye-reactive-messaging-kafka fails to reload when working with mvn quarkus:dev.
Instead it throws: https://gist.github.com/michalszynkiewicz/c71dba7a6f3d10b54adc3b2e2406a603

Changing the SmallRyeContextPropagationTemplate#configureStaticInit to: https://gist.github.com/michalszynkiewicz/eec489d443a675556ab5c95e0c728071 makes the app restart properly.

To Reproduce
Steps to reproduce the behavior:

mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create     -DprojectGroupId=com.example     -DprojectArtifactId=reproducer     -DclassName=com.example.ads.AdResource -Dpath=/ads -Dextensions=quarkus-smallrye-reactive-messaging-kafka,io.quarkus:quarkus-smallrye-reactive-messaging,quarkus-hibernate-orm-panache

cd reproducer; mvn clean compile quarkus:dev

in another konsole:


sed -e '13a ;' -i src/main/java/com/example/ads/AdResource.java
# or modify the fline somehow if you don't have sed

curl localhost:8080/ads

Environment (please complete the following information):

java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)
  • GraalVM version (if different from Java): not applicable

  • Quarkus version or git rev: f438459

Additional context
(Add any other context about the problem here.)

@michalszynkiewicz michalszynkiewicz added the kind/bug Something isn't working label May 28, 2019
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue May 28, 2019
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue May 28, 2019
@gsmet gsmet added this to the 0.16.0 milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants