Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis healthcheck message sometimes is not useful. #26885

Closed
OscarRL opened this issue Jul 22, 2022 · 1 comment · Fixed by #26886
Closed

Redis healthcheck message sometimes is not useful. #26885

OscarRL opened this issue Jul 22, 2022 · 1 comment · Fixed by #26886

Comments

@OscarRL
Copy link

OscarRL commented Jul 22, 2022

Describe the bug

There is some runtime exceptions that has no message when they are fired.

Actually the healthcheck performs a message with
return builder.down().withData("reason", "client [" + client.getKey() + "]: " + e.getMessage()).build();

Expected behavior

Reason should include a message that must explain what's happening on any exception.

Actual behavior

If getMessage() returns null the message is something like

"reason": "client [<default>]: null"

How to Reproduce?

  1. Setup a 1 second timeout.
  2. Connect to a redis that is lagging or with high workload.
  3. Wait to a healthcheck happend.
  4. Read the healthcheck message.

In this reproducer the atMost method of Mutiny will throw a TimeoutException that has no message ( null ).

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 22, 2022

cescoffier added a commit to cescoffier/quarkus that referenced this issue Jul 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 22, 2022
@gsmet gsmet modified the milestones: 2.12 - main, 2.11.1.Final Jul 26, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants