Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openshift deployment has a typo in the VCS annotation #29873

Closed
indiealexh opened this issue Dec 15, 2022 · 1 comment · Fixed by #29874
Closed

Openshift deployment has a typo in the VCS annotation #29873

indiealexh opened this issue Dec 15, 2022 · 1 comment · Fixed by #29874
Labels
area/kubernetes kind/bug Something isn't working
Milestone
2.15.1.Final

Comments

@indiealexh
Copy link

indiealexh commented Dec 15, 2022 •
edited
Loading

Describe the bug

Openshift deployment adds an annotation "app.quarkus.io/vcs-url" intended to add a link in the openshift workloads screen.

image

The correct annotation is "app.quarkus.io/vcs-uri"

Expected behavior

An "edit source code" button should be visible in the Openshift console on the workloads tab.

Actual behavior

Button is missing

Quarkus version or git rev

2.15.0
@indiealexh indiealexh added the kind/bug Something isn't working label Dec 15, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 15, 2022

/cc @geoand(openshift), @iocanel(openshift)

geoand added a commit to geoand/quarkus that referenced this issue Dec 15, 2022
@geoand
Use proper Openshift annotation for VCS
5f41306 
According to [this](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.11/html-single/building_applications/index#odc-labels-and-annotations-used-for-topology-view_viewing-application-composition-using-topology-view),
the proper annotation uses /vcs-uri instead of /vcs-url

Fixes: quarkusio#29873
@geoand geoand mentioned this issue Dec 15, 2022
Merged
iocanel added a commit that referenced this issue Dec 19, 2022
@iocanel
Merge pull request #29874 from geoand/#29873
976b500 
Use proper Openshift annotation for VCS
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 19, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 20, 2022
@geoand @gsmet
Use proper Openshift annotation for VCS
b7412be 
According to [this](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.11/html-single/building_applications/index#odc-labels-and-annotations-used-for-topology-view_viewing-application-composition-using-topology-view),
the proper annotation uses /vcs-uri instead of /vcs-url

Fixes: quarkusio#29873
(cherry picked from commit 5f41306)
ebullient pushed a commit to maxandersen/quarkus that referenced this issue Jan 24, 2023
@geoand @ebullient
Use proper Openshift annotation for VCS
4d3d29a 
According to [this](https://access.redhat.com/documentation/en-us/openshift_container_platform/4.11/html-single/building_applications/index#odc-labels-and-annotations-used-for-topology-view_viewing-application-composition-using-topology-view),
the proper annotation uses /vcs-uri instead of /vcs-url

Fixes: quarkusio#29873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging a pull request may close this issue.

Use proper Openshift annotation for VCS geoand/quarkus
2 participants
@indiealexh @gsmet