Reactive Postgres pipelining cannot be enabled

[franz1981]

Describe the bug

Setting pipelining level of a postgres reactive configuration is not picked it up by Vert-x while creating the connection pool.

Expected behavior

https://github.com/eclipse-vertx/vertx-sql-client/blob/a58127877a6fbb5b9ece9c58509637f699181826/vertx-pg-client/src/main/java/io/vertx/pgclient/spi/PgDriver.java#L48 requires

quarkus/extensions/reactive-pg-client/runtime/src/main/java/io/quarkus/reactive/pg/client/runtime/PgPoolRecorder.java

Line 94 in 85d9e17

poolOptions = new PoolOptions();

to allocate a PgPoolOptions options type to make the pipelining settings available while allocating the connection pool.

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @tsegismont (reactive-sql-clients), @vietj (reactive-sql-clients)

[geoand]

#32821 takes care of this

[tsegismont]

@geoand thank you for the quick fix.

I think we need additional changes:

• users shouldn't have to create a PgPoolCreator object, setting pipelining-limit in configuration should be enough
• Pg client is not the only one affected, MySQL and DB2 are affected too

I'm out of the office and will return on May 2. If can take care of this when I'm back.

[franz1981]

Thanks @tsegismont !

[tsegismont]

I think we need additional changes:

I gave this a second thought, we need to revert #32821

PgPoolOptions is an impl detail, it should not be exposed. It is created internally when the user wants a pooled client, not a connection pool (see https://vertx.io/docs/vertx-pg-client/java/#_pool_versus_pooled_client).

What Quarkus shall provide to users is a connection pool, not a pooled client. Pipelining for Quarkus users is possible, provided they acquire a connection and then submit several queries at once instead of waiting results between queries.

[geoand]

How would we provide a proper pool? What needs to be configured in Vertx?

[franz1981]

Yeah, and not only: at this point why we should expose pipelining config in Quarkus if we currently cannot make use of it?

[geoand]

What Quarkus shall provide to users is a connection pool, not a pooled client. Pipelining for Quarkus users is possible, provided they acquire a connection and then submit several queries at once instead of waiting results between queries.

Care to elaborate on this a little further please?

[vietj]

@geoand Thomas refers to this https://vertx.io/docs/vertx-pg-client/java/#_pool_versus_pooled_client

[geoand]

Thanks @vietj.

Reading that, I don't really see how Quarkus users can use pipelining. @tsegismont I see you have assigned yourself to the issue, so I guess I'll just wait for the PR :)

[vietj]

@geoand they can use the pool to acquire a connection, then do pipelining over this connection and then release the connection

[geoand]

Understood, thanks

[tsegismont]

I see you have assigned yourself to the issue, so I guess I'll just wait for the PR :)

@geoand sorry if I wasn't clear enough in #32822 (comment)

As @vietj explained later, pipelining can be used by:

• activating the feature in the config
• getting a connection from the pool and sending queries without waiting for results

No changes are needed, so I'm closing the issue

[geoand]

@tsegismont thanks.

I would like it if we could add some docs to Quarkus about how to do that.

[tsegismont]

Sounds good. I'll take care of this.

[geoand]

Thanks!

…

On Wed, May 3, 2023, 15:14 Thomas Segismont ***@***.***> wrote: Sounds good. I'll take care of this. — Reply to this email directly, view it on GitHub <#32822 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP37ABIALTO6NS7FBJDXEJDZFANCNFSM6AAAAAAXG74FUE> . You are receiving this because you were mentioned.Message ID: ***@***.***>