-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sse difference in empty event between non-reactive and reactive output #37033
Comments
/cc @FroMage (resteasy-reactive), @stuartwdouglas (resteasy-reactive) |
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033
#37036 fixes the issue |
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033
Use empty string in Sse event when there is no data
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033
#35990 was backported, so I think this one should be as well |
@michalvavrik triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request. This message is automatically generated by a bot. |
sorry |
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033 (cherry picked from commit 042aed2)
Using an empty string instead of null is what the classic rest client does, so let's align with it Closes: quarkusio#37033
Describe the bug
When sending event with empty data using reactive way the empty data is transformed in null. The same code using non-reactive return just empty data (which I think is correct).
Happening with
quarkus-resteasy-reactive-*
. More info available in reproducers.Expected behavior
The reactive and non-reactive should have same output.
Actual behavior
With non-reactive output is
With reactive output is
How to Reproduce?
For non-reactive
git clone -b sse-non-reactive [email protected]:jedla97/quarkus-reproducers.git
cd quarkus-reproducers
mvn quarkus:dev -Dquarkus.platform.version=3.5.1
Go to http://127.0.0.1:8080/sse/client
For reactive
git checkout sse-native-method-404
mvn quarkus:dev -Dquarkus.platform.version=3.5.1
Go to http://127.0.0.1:8080/sse/client
The output is show in actual behavior section
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: