Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtemisTestResource available #3833

Closed
lordofthejars opened this issue Sep 3, 2019 · 1 comment · Fixed by #5900
Closed

ArtemisTestResource available #3833

lordofthejars opened this issue Sep 3, 2019 · 1 comment · Fixed by #5900
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@lordofthejars
Copy link
Contributor

Description
Artemis integration test has an ArtemisTestResource https://github.com/quarkusio/quarkus/pull/2930/files#diff-76fa3fe6358cacc251f9cb4d29ae82ac to manage the lifecycle of an embedded Artemis instance for testing purposes.

The problem is that this class is not available for all users, I think that this kind of utilities should be available for any user because the way we test these integrations might be used by any dev.

So I think that this class should be moved to either an artemis-test artifact or in a place that can be used by anyone.

Generally speaking, I think that any util used in our integration tests should not be implemented in the integration tests itself but in a place that could be used by anyone, because at the end our necessities for testing probably are going to be the same for anyone writing test for Quarkus.

@lordofthejars lordofthejars added the kind/enhancement New feature or request label Sep 3, 2019
@gastaldi gastaldi added the good first issue Good for newcomers label Nov 8, 2019
@uaihebert
Copy link
Contributor

Hello, I create a PR for this issue. Let me know what should be improved.

@gsmet gsmet added this to the 1.1.0 milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants