-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/create artemis test module #5900
Feature/create artemis test module #5900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, my only comment is on placement of the new module
extensions/artemis-test/pom.xml
Outdated
</parent> | ||
|
||
<modelVersion>4.0.0</modelVersion> | ||
<artifactId>quarkus-artemis-test</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should put this test module under quarkus/test-framework/
with the other test modules, and set the pom parent to quarkus-test-framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @aguibert's comment in https://github.com/quarkusio/quarkus/pull/5900/files#r352410389. The module should be moved under quarkus-test-framework
Agreed and you will need to name it |
That looks good. Can you squash all your commits in a single one? Thank you! |
3358056
to
51179a7
Compare
@gastaldi sure, no problem. |
d4e99a5
to
5a8448a
Compare
5a8448a
to
93bba85
Compare
hello @gastaldi the build failed on the windows test. any tip for what should I look in the log? the logs are huge and I could not find the error in there. |
@uaihebert it doesn't seem related to your changes, let me see if I can trigger the build again |
hello @gastaldi indeed it was not related. let me know if you need anything else. |
@uaihebert Merged. Thank you! |
thank you too. |
Fixes #3833
The idea of this pr is: