Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Metrics extension use Vert.x instead of Servlets #4159

Closed
gsmet opened this issue Sep 23, 2019 · 4 comments · Fixed by #4174
Closed

Make Metrics extension use Vert.x instead of Servlets #4159

gsmet opened this issue Sep 23, 2019 · 4 comments · Fixed by #4174
Assignees
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Sep 23, 2019

Per discussion with @jmartisk .

See this PR #4062 for some examples.

@gastaldi
Copy link
Contributor

That looks interesting. May I give it a try or is this already being worked on by someone else?

@jmartisk
Copy link
Contributor

I'm planning to do that, per discussion in #4151 if you don't mind :) yeah it does sound like an interesting task. I suppose there must be some more extensions that still need the same

@gastaldi
Copy link
Contributor

I'm planning to do that, per discussion in #4151 if you don't mind :)

@jmartisk not at all, by all means 😉

@gsmet can this issue be assigned to @jmartisk ?

@geoand
Copy link
Contributor

geoand commented Sep 24, 2019

Does is make sense to open a similar issue for Opentracing? That one relies on servlets in the way of providing a Servlet filter.

jmartisk added a commit to jmartisk/quarkus that referenced this issue Sep 24, 2019
@gsmet gsmet added this to the 0.24.0 milestone Sep 24, 2019
jmartisk added a commit to jmartisk/quarkus that referenced this issue Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants