Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Doc - Clarify confusing sourceType/sourceClass #43175

Closed
gsmet opened this issue Sep 10, 2024 · 1 comment
Closed

Config Doc - Clarify confusing sourceType/sourceClass #43175

gsmet opened this issue Sep 10, 2024 · 1 comment
Labels
area/config kind/enhancement New feature or request

Comments

@gsmet
Copy link
Member

gsmet commented Sep 10, 2024

Description

With the addition of metadata for the Spring metadata format, we end up with the confusing sourceClass/sourceType, with sourceClass being what we push to the Spring metadata sourceType in the end.

This is very confusion, we need to fix it.

Implementation ideas

No response
@gsmet gsmet added the kind/enhancement New feature or request label Sep 10, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 10, 2024

/cc @radcortez (config)

@gsmet gsmet closed this as completed by moving to Done in WG - Quarkus Config and IDEs Sep 10, 2024
gsmet added a commit to gsmet/quarkus that referenced this issue Sep 10, 2024
@gsmet
Config Doc - Clarify sourceClass/sourceType
1f3b5b1 
In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
gsmet added a commit to gsmet/quarkus that referenced this issue Sep 13, 2024
@gsmet
Config Doc - Clarify sourceClass/sourceType
fef1905 
In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
gsmet added a commit to gsmet/quarkus that referenced this issue Sep 13, 2024
@gsmet
Config Doc - Clarify sourceClass/sourceType
3e4c8d0 
In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
gsmet added a commit to gsmet/quarkus that referenced this issue Sep 30, 2024
@gsmet
Config Doc - Clarify sourceClass/sourceType
4238936 
In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
gsmet added a commit to gsmet/quarkus that referenced this issue Oct 17, 2024
@gsmet
Config Doc - Clarify sourceClass/sourceType
76915e4 
In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
@gsmet @bschuhmann
Config Doc - Clarify sourceClass/sourceType
2e77ea5 
In the light of the Spring config metadata, let's get rid of sourceClass
and let's avoid using sourceType for the field/method type as it's
confusing.

Fixes quarkusio#43175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/config kind/enhancement New feature or request
Projects
WG - Quarkus Config and IDEs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gsmet