Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.google.code.findbugs:jsr305 from gRPC #44325

Closed
mabartos opened this issue Nov 5, 2024 · 3 comments · Fixed by #44328
Closed

Remove com.google.code.findbugs:jsr305 from gRPC #44325

mabartos opened this issue Nov 5, 2024 · 3 comments · Fixed by #44328
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone

Comments

@mabartos
Copy link
Contributor

mabartos commented Nov 5, 2024

Description

Is it necessary to have included the com.google.code.findbugs:jsr305 dependency for gRPC common extension?

The latest release of this dependency was 2017 and it moved to com.github.spotbugs:spotbugs-annotations.

Is it possible to revisit it and if necessary, using the spotbugs-annotations ?

Related to keycloak/keycloak#34396

Implementation ideas

No response

@mabartos mabartos added the kind/enhancement New feature or request label Nov 5, 2024
Copy link

quarkus-bot bot commented Nov 5, 2024

/cc @alesj (grpc), @cescoffier (grpc)

@cescoffier
Copy link
Member

If I'm not mistaken it is used in the generate Java code.

@cescoffier
Copy link
Member

My bad, it's not the case. It's a dependency of grpc-core, that seems to have been removed. We would need to test without it.

mabartos added a commit to mabartos/quarkus that referenced this issue Nov 5, 2024
mabartos added a commit to mabartos/quarkus that referenced this issue Nov 5, 2024
gsmet pushed a commit to mabartos/quarkus that referenced this issue Nov 12, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 12, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants