QuarkusTest: consider removing the test profile support for @Nested tests

[mkouba]

Currently, it is possible to specify a test profile for a @Nested test (inner class of a top-level test class). However, this may cause troubles if the enclosing test class defines a different test profile; i.e. the enclosing class should be tested against a different application build. Keep in mind that Quarkus always needs to obtain the instance of the enclosing test class from the CDI container.

More specifically, if a CDI bean Foo is only enabled in the profile FooProfile then it cannot be injected in the test class FooTest because it would cause unsatisfied dependency in the test class FooTest$FooNested:

@TestProfile(FooProfile.class) // -> enables Foo
public class FooTest {
   
    @Inject Foo foo; // this is legal and works fine when FooTest#test() is run

    void test() {
       // ...
    }

   @Nested
   @TestProfile(FooNestedProfile.class) // -> Foo is not enabled here
   class FooNested {
     
      void test() {
         // ...this test always fails because when the test app is built FooTest#foo results in an unsatisfied dependency
      } 
     
   }

}

[mkouba]

CC @Ladicek @geoand @manovotn @holly-cummins

[quarkus-bot]

/cc @geoand (testing)

[geoand]

@holly-cummins didn't you run into something similar?

[mkouba]

@holly-cummins didn't you run into something similar?

There was a discussion on zulip in the "WG 30 Test Classloading chatter" channel: https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/WG.20.2330.20Test.20Classloading.20chatter/near/484875724

[geoand]

In any case, +1

[manovotn]

Same here, +1

[holly-cummins]

I ended up doing this as part of #34681 (not yet merged, and huge). I'm happy to see another reason to do it.

I'll mark this as resolved by that PR for now, but I might split it out and ship it earlier, in the interests of small changes.

[manovotn]

I ended up doing this as part of #34681 (not yet merged, and huge). I'm happy to see another reason to do it.

I'll mark this as resolved by that PR for now, but I might split it out and ship it earlier, in the interests of small changes.

Awesome, thank you! :)