Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Client - Config - Some properties should be optional #4707

Closed
gsmet opened this issue Oct 21, 2019 · 1 comment · Fixed by #4735
Closed

Kubernetes Client - Config - Some properties should be optional #4707

gsmet opened this issue Oct 21, 2019 · 1 comment · Fixed by #4735
Assignees
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Oct 21, 2019

Nearly all the properties are required, whereas I'm pretty sure they should be optional (typically the proxy stuff).

Please use Optional where it makes sense.

@geoand @gastaldi could you have a look? It's not high priority but I just included the generated doc and it ends up with required everywhere.

I'm also wondering if most of the config should be runtime instead of build time?

@geoand
Copy link
Contributor

geoand commented Oct 21, 2019

I'll check it out

@geoand geoand self-assigned this Oct 21, 2019
geoand added a commit to geoand/quarkus that referenced this issue Oct 22, 2019
geoand added a commit to geoand/quarkus that referenced this issue Oct 22, 2019
gsmet added a commit that referenced this issue Oct 22, 2019
Make KubernetesClientConfig values Optional
CSTDev pushed a commit to CSTDev/quarkus that referenced this issue Oct 22, 2019
@gsmet gsmet added this to the 0.27.0 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants