Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepend a slash to a io.quarkus.vertx.web.Route.path if not present #4835

Closed
mkouba opened this issue Oct 24, 2019 · 2 comments · Fixed by #4845
Closed

Prepend a slash to a io.quarkus.vertx.web.Route.path if not present #4835

mkouba opened this issue Oct 24, 2019 · 2 comments · Fixed by #4845
Assignees
@qrman
Labels
area/vertx good first issue Good for newcomers kind/enhancement New feature or request
Milestone
0.27.0

Comments

@mkouba
Copy link
Contributor

mkouba commented Oct 24, 2019

A Route path must start with a /. So if a user declares @Route(path = "hello") Quarkus fails during RUNTIME_INIT. I think we should prepend the slash automatically if not present. For the record - JAX-RS @Path can have both values, ie. @Path("hello") and @Path("/hello").
@mkouba mkouba added kind/enhancement New feature or request good first issue Good for newcomers area/vertx labels Oct 24, 2019
@qrman
Copy link

qrman commented Oct 24, 2019

Hi, can I take this issue?

@mkouba
Copy link
Contributor Author

mkouba commented Oct 24, 2019

@qrman Of course, go ahaead! ;-)

qrman added a commit to qrman/quarkus that referenced this issue Oct 24, 2019
@qrman
quarkusio#4835 |
bf078a4
@qrman qrman mentioned this issue Oct 24, 2019
Merged
stuartwdouglas added a commit that referenced this issue Oct 24, 2019
@stuartwdouglas
Merge pull request #4845 from qrman/#4835-Path-without-slash
fe5e5d6 
prepend the slash automatically if not present
@mkouba mkouba added this to the 0.27.0 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qrman qrman

Labels
area/vertx good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

prepend the slash automatically if not present qrman/quarkus
2 participants
@mkouba @qrman