Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vert.x also provides a JSON implementation so no warning should be emitted #5614

Closed
gsmet opened this issue Nov 20, 2019 · 2 comments · Fixed by #5623
Closed

Vert.x also provides a JSON implementation so no warning should be emitted #5614

gsmet opened this issue Nov 20, 2019 · 2 comments · Fixed by #5623
Assignees
@machi1990
Labels
kind/bug Something isn't working
Milestone
1.0.0.Final

Comments

@gsmet
Copy link
Member

gsmet commented Nov 20, 2019

Since #4165 , we emit a warning if our REST services produce JSON and we don't have any of the RESTEasy JSON extensions:

[WARNING] [io.quarkus.resteasy.common.deployment.ResteasyCommonProcessor] Quarkus detected the need of REST JSON support but you have not provided the necessary JSON extension for this. You can visit https://quarkus.io/guides/rest-json for more information on how to set one.

Problem is: Vert.x also has the ability to serialize JSON via the Vert.x JSON types.

I think we should drop the warning also when we have the full Vert.x extension around.

See the Reactive MySQL client IT for an example of this issue.
@gsmet gsmet added the kind/bug Something isn't working label Nov 20, 2019
@gsmet
Copy link
Member Author

gsmet commented Nov 20, 2019

@machi1990 could you have a look at that one? I'd like to get it fixed for the Final we plan to release on Monday.

@machi1990
Copy link
Member

machi1990 commented Nov 20, 2019 •
edited
Loading

Makes sense. Will check it a bit later :-)

@machi1990 machi1990 self-assigned this Nov 20, 2019
machi1990 added a commit to machi1990/quarkus that referenced this issue Nov 20, 2019
@machi1990
fix(vertx): do not log a warning about missing json support when vert…
f20beb3 
…x extension is present

Vert.x also provides a JSON implementation so no warning should be emitted

Fixes quarkusio#5614
@machi1990 machi1990 mentioned this issue Nov 20, 2019
Merged
machi1990 added a commit to machi1990/quarkus that referenced this issue Nov 20, 2019
@machi1990
fix(vertx): do not log a warning about missing json support when vert…
ab682b2 
…x extension is present

Vert.x also provides a JSON implementation so no warning should be emitted

Fixes quarkusio#5614
@gsmet gsmet added this to the 1.1.0 milestone Nov 20, 2019
@gsmet gsmet removed the backport? label Nov 22, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 22, 2019
Simulant87 pushed a commit to Simulant87/quarkus that referenced this issue Nov 23, 2019
@machi1990 @Simulant87
fix(vertx): do not log a warning about missing json support when vert…
a825d6a 
…x extension is present

Vert.x also provides a JSON implementation so no warning should be emitted

Fixes quarkusio#5614
Simulant87 pushed a commit to Simulant87/quarkus that referenced this issue Nov 23, 2019
@machi1990 @Simulant87
fix(vertx): do not log a warning about missing json support when vert…
6d1a7d8 
…x extension is present

Vert.x also provides a JSON implementation so no warning should be emitted

Fixes quarkusio#5614
gsmet pushed a commit that referenced this issue Nov 24, 2019
@machi1990 @gsmet
fix(vertx): do not log a warning about missing json support when vert…
a590149 
…x extension is present

Vert.x also provides a JSON implementation so no warning should be emitted

Fixes #5614
mmusgrov pushed a commit to mmusgrov/quarkus that referenced this issue Dec 13, 2019
@machi1990 @mmusgrov
fix(vertx): do not log a warning about missing json support when vert…
de5a4a0 
…x extension is present

Vert.x also provides a JSON implementation so no warning should be emitted

Fixes quarkusio#5614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machi1990 machi1990

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.0.0.Final
2 participants
@gsmet @machi1990