Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin DSL Gradle projects when adding/listing/removing extensions #5776

Closed
pschyma opened this issue Nov 26, 2019 · 4 comments · Fixed by #9353
Closed

Support Kotlin DSL Gradle projects when adding/listing/removing extensions #5776

pschyma opened this issue Nov 26, 2019 · 4 comments · Fixed by #9353
Assignees
Labels
Milestone

Comments

@pschyma
Copy link

pschyma commented Nov 26, 2019

Describe the bug
The addExtension gradle task does not honor kotlin DSL build files and creates instead empty groovy DSL build configuration files: build.gradle and settings.gradle.

Expected behavior
Adding an extension should create a new entry in the dependencies block of the existing build.gradle.kts file.

Actual behavior
Nothing is added to build.gradle.kts, but instead build.gradle and settings.gradle files are created.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new gradle kotlin DSL project
  2. Add quarkus plugin
  3. Execute `./gradlew addExtension --extensions="agroal"
**Environment (please complete the following information):**
 - Output of `uname -a` or `ver`: Linux voyager 5.4.0-arch1-1 #1 SMP PREEMPT Mon, 25 Nov 2019 22:31:57 +0000 x86_64 GNU/Linux
 - Output of `java -version`: 
openjdk version "1.8.0_232"
OpenJDK Runtime Environment (build 1.8.0_232-20191008104205.buildslave.jdk8u-src-tar--b07)
OpenJDK 64-Bit GraalVM CE 19.3.0 (build 25.232-b07-jvmci-19.3-b05, mixed mode)
 - GraalVM version (if different from Java): 
 - Quarkus version or git rev: 1.0.0.Final
@pschyma pschyma added the kind/bug Something isn't working label Nov 26, 2019
@geoand geoand added the area/gradle Gradle label Nov 26, 2019
@geoand
Copy link
Contributor

geoand commented Nov 26, 2019

Currently we don't handle build.gradle.kts at all. It would be a nice addition.

@gsmet gsmet added the good first issue Good for newcomers label Nov 27, 2019
@RotBolt
Copy link
Contributor

RotBolt commented Dec 29, 2019

I would like to take this issue :)

@ghost
Copy link

ghost commented May 3, 2020

@kaenlupus Any progress on this?

@RotBolt
Copy link
Contributor

RotBolt commented May 3, 2020

Unfortunately, no. We have to deal with other Kotlin stuff and support. Kotlin is still in experimental phase. Trying to improve the support

@emmanuelbernard emmanuelbernard removed the kind/bug Something isn't working label Jun 30, 2020
@ia3andy ia3andy changed the title Honor Kotlin DSL gradle builds Support Kotlin DSL Gradle projects when adding/listing/removing extensions Jul 1, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants