Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] Add Gradle Kotlin DSL as another build tool option when generating a new Quarkus projects #5807

Closed
hantsy opened this issue Nov 27, 2019 · 13 comments
Assignees
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kotlin
Milestone

Comments

@hantsy
Copy link
Contributor

hantsy commented Nov 27, 2019

Add Gradle Kotlin DSL as another build tool option, or add a using Kotlin DSL checkbox when Gradle is selected.

@ia3andy
Copy link
Contributor

ia3andy commented Nov 27, 2019

@maxandersen @geoand any thoughts?

@geoand
Copy link
Contributor

geoand commented Nov 27, 2019

I think we need to mature the Gradle support first. This would be a nice addition after that

@ia3andy
Copy link
Contributor

ia3andy commented Nov 27, 2019

@geoand thanks, I move the issue to Quarkus main repo then.

@ia3andy ia3andy transferred this issue from quarkusio/code.quarkus.io Nov 27, 2019
@ia3andy ia3andy changed the title Add Gradle Kotlin DSL as another build tool option. [devtools] Add Gradle Kotlin DSL as another build tool option. Nov 27, 2019
@ia3andy
Copy link
Contributor

ia3andy commented May 19, 2020

@maxandersen I think this should wait for the refactor #8178 (and maybe done just after it?)

@ia3andy ia3andy self-assigned this May 19, 2020
@ia3andy ia3andy added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 19, 2020
@ghost
Copy link

ghost commented Jun 7, 2020

+1

@ia3andy
Copy link
Contributor

ia3andy commented Jun 8, 2020

@maxandersen Would it be activated when you select Kotlin and Gradle together? Maybe you could want it without Kotlin in the code? Or would it be a plain "Gradle Kotlin" Built Tool?

The problem with the latest would be to have 2 Gradle vs 1 Maven options no?

@ghost
Copy link

ghost commented Jun 9, 2020

@maxandersen Would it be activated when you select Kotlin and Gradle together? Maybe you could want it without Kotlin in the code? Or would it be a plain "Gradle Kotlin" Built Tool?

The problem with the latest would be to have 2 Gradle vs 1 Maven options no?

I think kotlin DSL is more elegant with a Gradle Kotlin project. That's also what Spring initializr generates by default for a gradle kotlin project, and would be good to have similar behaviour for generating new quarkus projects.

@emmanuelbernard
Copy link
Member

Let's close this one as it's a duplicate of #5776

@emmanuelbernard emmanuelbernard added the triage/duplicate This issue or pull request already exists label Jun 30, 2020
@ia3andy ia3andy changed the title [devtools] Add Gradle Kotlin DSL as another build tool option. [devtools] Add Gradle Kotlin DSL as another build tool option when generating a new Quarkus projects Jul 1, 2020
@ia3andy
Copy link
Contributor

ia3andy commented Jul 1, 2020

@emmanuelbernard I am re-opening this one, there is a clear distinction between handling existing projects that use Gradle with Kotlin DSL (#5776) and generating new Quarkus project using Gradle with Kotlin DSL as a buildtool option (this one).

@ia3andy ia3andy reopened this Jul 1, 2020
@ia3andy ia3andy removed the triage/duplicate This issue or pull request already exists label Jul 1, 2020
@ia3andy
Copy link
Contributor

ia3andy commented Jul 1, 2020

This option will be easy to implement when #10372 gets merged

@ia3andy
Copy link
Contributor

ia3andy commented Jul 1, 2020

We would just need create a new Gradle buildtool Codestart strongly inspired by the Gradle one: https://github.com/ia3andy/quarkus/tree/codestarts-v0/devtools/platform-descriptor-json/src/main/resources/codestarts/base/buildtool/gradle

@Legion2
Copy link

Legion2 commented Feb 13, 2021

@ia3andy #10372 was merged, what is the status of this issue?

@ia3andy
Copy link
Contributor

ia3andy commented Feb 15, 2021

Thanks @Legion2, yeah it's done

@ia3andy ia3andy closed this as completed Feb 15, 2021
@gsmet gsmet added this to the 1.7.0.CR1 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kotlin
Projects
None yet
Development

No branches or pull requests

6 participants