-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpringJPA: Support spring.jpa.show-sql #6192
Comments
TBH I don't have a proper solution in my head, so I would suggest you go ahead and experiment and see what actually works best. |
I think this asks a broader question: should we support the whole Spring configuration? Because once we have added one, it's weird to not support the others. I must admit that I'm not sold to it. |
I am also against adding support because it then open doors other types of Java config for Spring. Would however explore if we can detect some specific configuration options that the user might have added and perhaps propose the proper Quarkus alternatives? |
That would be handy and probably relatively easy to implement. |
Related to quarkusio#6192
Related to quarkusio#6192
Related to quarkusio#6192
Related to quarkusio#6192
Related to quarkusio#6192
Related to quarkusio#6192
I see #6291 was merged; should we close this one? |
Definitely, thanks for catching it @Sanne |
Description
From a Hackaton with Quarkus suggestions and feedbacks:
User tried to set spring.jpa.show-sql was surprised it didn’t work.
Implementation ideas
My idea is create a
@ConfigRoot
and@ConfigGroup
classes to load this property and map it to the currentquarkus.hibernate-orm.log.sql
. Anyway the new spring property would be namedquarkus.spring.jpa.show-sql
, we cannot escape to havequarkus
in the name. WDYT @geoand ?The text was updated successfully, but these errors were encountered: