Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringJPA: Support spring.jpa.show-sql #6192

Closed
aureamunoz opened this issue Dec 16, 2019 · 6 comments
Closed

SpringJPA: Support spring.jpa.show-sql #6192

aureamunoz opened this issue Dec 16, 2019 · 6 comments
Assignees
Labels
area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Milestone

Comments

@aureamunoz
Copy link
Member

aureamunoz commented Dec 16, 2019

Description
From a Hackaton with Quarkus suggestions and feedbacks:
User tried to set spring.jpa.show-sql was surprised it didn’t work.

Implementation ideas
My idea is create a @ConfigRoot and @ConfigGroup classes to load this property and map it to the current quarkus.hibernate-orm.log.sql. Anyway the new spring property would be named quarkus.spring.jpa.show-sql, we cannot escape to have quarkus in the name. WDYT @geoand ?

@aureamunoz aureamunoz added the kind/enhancement New feature or request label Dec 16, 2019
@geoand geoand added the area/spring Issues relating to the Spring integration label Dec 17, 2019
@geoand
Copy link
Contributor

geoand commented Dec 17, 2019

TBH I don't have a proper solution in my head, so I would suggest you go ahead and experiment and see what actually works best.

@gsmet
Copy link
Member

gsmet commented Dec 17, 2019

I think this asks a broader question: should we support the whole Spring configuration? Because once we have added one, it's weird to not support the others.

I must admit that I'm not sold to it.

@geoand
Copy link
Contributor

geoand commented Dec 17, 2019

I am also against adding support because it then open doors other types of Java config for Spring. Would however explore if we can detect some specific configuration options that the user might have added and perhaps propose the proper Quarkus alternatives?

@gsmet
Copy link
Member

gsmet commented Dec 17, 2019

Would however explore if we can detect some specific configuration options that the user might have added and perhaps propose the proper Quarkus alternatives?

That would be handy and probably relatively easy to implement.

aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 20, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 23, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 23, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 26, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 26, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 26, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 26, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Dec 27, 2019
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 2, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 2, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 2, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 2, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 2, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 2, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Jan 13, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 3, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 4, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 4, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 7, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 7, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 11, 2020
aureamunoz added a commit to aureamunoz/quarkus that referenced this issue Feb 11, 2020
@Sanne
Copy link
Member

Sanne commented Mar 27, 2020

I see #6291 was merged; should we close this one?

@geoand
Copy link
Contributor

geoand commented Mar 27, 2020

Definitely, thanks for catching it @Sanne

@geoand geoand closed this as completed Mar 27, 2020
@gsmet gsmet added triage/out-of-date This issue/PR is no longer valid or relevant and removed triage/out-of-date This issue/PR is no longer valid or relevant labels Apr 7, 2020
@gsmet gsmet added this to the 1.3.0.CR1 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants