Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surefire 3.0.0-M4 passing even if a build step throws an exception #7203

Closed
ppalaga opened this issue Feb 14, 2020 · 0 comments · Fixed by #7214
Closed

Surefire 3.0.0-M4 passing even if a build step throws an exception #7203

ppalaga opened this issue Feb 14, 2020 · 0 comments · Fixed by #7214
Labels
kind/bug Something isn't working
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Feb 14, 2020

Quarkus is currently using maven-surefire-plugin 2.22.1 with which this issue does not occur. The issue is occurring in Camel Quarkus where we use maven-surefire-plugin 3.0.0-M4. But wit ha few changes, the issue is reproducible also in Quarkus.

Steps to reproduce:

  1. Add throw new RuntimeException("This is failing"); at the end of io.quarkus.hibernate.validator.deployment.HibernateValidatorProcessor.registerAdditionalBeans()

  2. rebuild the validator extension

cd extensions/hibernate-validator
mvn clean install -DskipTests
  1. run the validator itest
cd integration-tests/hibernate-validator
mvn clean test

This fails as expected because we are still on maven-surefire-plugin 2.22.1

  1. Upgrade to maven-surefire-plugin 3.0.0-M4 in the top pom.xml

  2. Run the validator test again

cd integration-tests/hibernate-validator
mvn clean test

Expected: the test and the whole maven build fails
Actual:

[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.quarkus.it.hibernate.validator.HibernateValidatorFunctionalityTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.649 s - in io.quarkus.it.hibernate.validator.HibernateValidatorFunctionalityTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS

cc @aloubyansky

@ppalaga ppalaga added the kind/bug Something isn't working label Feb 14, 2020
stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Feb 15, 2020
If boot fails report it on the first test execution,
then skip all subsequent tests.

Fixes quarkusio#7203
@gsmet gsmet added this to the 1.3.0 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants