Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigPhase.BUILD_AND_RUN_TIME_FIXED root values not restored at runtime #962

Closed
starksm64 opened this issue Feb 20, 2019 · 4 comments · Fixed by #3278
Closed

ConfigPhase.BUILD_AND_RUN_TIME_FIXED root values not restored at runtime #962

starksm64 opened this issue Feb 20, 2019 · 4 comments · Fixed by #3278
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@starksm64
Copy link
Contributor

Further progress on the #780 config testing is showing that a config root using ConfigPhase.BUILD_AND_RUN_TIME_FIXED does not see the build time values restored by the generated ConfigHelper class. I'm guessing that an ObjectSubstitution is not being generated, but need to look into this more.

@starksm64 starksm64 added the kind/bug Something isn't working label Feb 20, 2019
@starksm64 starksm64 self-assigned this Feb 20, 2019
@starksm64
Copy link
Contributor Author

All that is being generated is the default initialization code. The ObjectSubstitution approach will not work as I'm looking at the code because the generated ObjectLoader takes precedence. The initialization code simply needs to be a serialization of the object. Is there a utility/code that writes out an object in gizmo or the codebase?

@dmlloyd
Copy link
Member

dmlloyd commented Feb 20, 2019

No, it's a bit more complex than that unfortunately. My current plan is to bake the build config in as a build-config.properties and load it in a separate pass during static init using the same loader code.

@dmlloyd
Copy link
Member

dmlloyd commented Feb 20, 2019

The ConfigDefinition class was designed to be a monolithic view of all config, but now it seems like it might be better to have some kind of better separation between build config, build config that's visible at run time, and run time config. This also ties into #860 and needing to load the run time config during the main method only, so I can support command line arguments which affect config processing.

@starksm64 starksm64 assigned dmlloyd and unassigned starksm64 Feb 20, 2019
@starksm64
Copy link
Contributor Author

Ok, I see. I have assigned this to you.

dmlloyd added a commit to dmlloyd/quarkus that referenced this issue Jul 18, 2019
@aloubyansky aloubyansky added this to the 0.20.0 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants