Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper wait strategy for mysql container #10026

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Use proper wait strategy for mysql container #10026

merged 1 commit into from
Jun 17, 2020

Conversation

aguibert
Copy link
Member

Follow-on from PR #9988

CC @geoand

geoand
geoand approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aguibert aguibert requested a review from geoand June 15, 2020 17:54
@geoand
Copy link
Contributor

geoand commented Jun 16, 2020

@aguibert mind rebasing onto master? There are CI fixes that should make CI pass and everyone more comfortable :)

@aguibert aguibert force-pushed the reactive-mysql-it-container-wait branch from 65e19e1 to 339eb4f Compare June 16, 2020 13:47
@aguibert
Copy link
Member Author

@geoand sure, rebased and pushed

@gsmet gsmet merged commit f7f54a2 into quarkusio:master Jun 17, 2020
@gsmet gsmet added this to the 1.6.0 - master milestone Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand Awaiting requested review from geoand

Assignees

@aguibert aguibert

Labels
area/reactive
Projects
None yet
Milestone
1.6.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@aguibert @geoand @gsmet