Changed the maximum size of request body allowed in HTTP request

[harshmadhani]

I have made changes to the maximum size allowed for a HTTP request body by default from unlimited to 2 MB. This is to resolve the #10079 issue

[geoand]

Thanks for this!

I am not sure it's the proper default though. @stuartwdouglas what does Undertow default to?

[jaikiran]

From what I can see[1] Undertow itself leaves it undefined (i.e. no limit). However, in WildFly server (which underneath uses Undertow), it's default set to 10MB as an upper limit[2]

[1] https://github.com/undertow-io/undertow/blob/master/core/src/main/java/io/undertow/UndertowOptions.java#L49

[2] https://github.com/wildfly/wildfly/blob/master/undertow/src/main/resources/schema/wildfly-undertow_11_0.xsd#L90 (the max-post-size ultimately translates to the UndertowOptions.MAX_ENTITY_SIZE https://github.com/wildfly/wildfly/blob/330da67750e2b9c910c384723cdbff6f5ac32ec2/undertow/src/main/java/org/wildfly/extension/undertow/ListenerResourceDefinition.java#L150)

[stuartwdouglas]

I think 10mb makes more sense than 2mb. In general though this is very hard to put a meaningful limit on, as different systems have different requirements. If you are processing a REST request and fully buffering the request that if you are uploading a file and writing the data to disk as it comes in.

[geoand]

Thanks for the input folks. So I think we agree that 10MB is a better default. @harshmadhani can you please update the PR?

[harshmadhani]

@geoand yes I guess 10 MB is a better default. I will update the PR.

[geoand]

Can you please squash the commits into a single one?

[harshmadhani]

@geoand ok let me raise a seperate merge request for the same. I will close this one