Rethink closing strategy of the ThreadLocalPool optimised pgpool #10228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I can't review this besides rubber-stamping it. This concurrency stuff is not something I'm familiar with. |
|
I mean, I can definitely rubber-stamp this if that's what you're after, but I suspect you want someone to actually understand what you changed, right? If yes, I'm not qualified. |
|
Ok I'll take the rubber-stamp then :) If there's issues, I'll fix them Re-pushed as there was a formatting issue. |
|
CI is passing |
|
great. Could you merge it @geoand ? I think Stephane mentioned going on PTO and we need the feature - this code is all disabled by default so should be low risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been tinkering with the new pool a bit.
The main improvement is that the thredlocals and their matching List of opened pools is being treated as a single element of state, so stored together and closed as one. Before you could have some odd situations with the list being attempted to be modified during a close, or viceversa.
Should still be very efficient, however I didn't test that.