Qute - remove standalone lines by default #10305
Conversation
mkouba
commented
Jun 26, 2020
mkouba
commented
- resolves Qute: remove whitespace around type declarations #8753
|
2 fast 2 furious @mkouba 😂 🍻 that's awesome... I'll have a look on monday if you don't mind? |
|
Ah, I forgot that |
|
I have an error, I am rebuilding everything to make sure it's not due to my env.. |
|
@ia3andy no problem. Let me know if you hit a problem... |
| public void testRemoveStandaloneLines() { | ||
| Engine engine = Engine.builder().addDefaults().removeStandaloneLines(true).build(); | ||
| String content = "{@java.lang.String foo}\n" // -> standalone | ||
| + "\n" |
There was a problem hiding this comment.
So, this appears to validate that the description:
A standalone line is a line that contains only section tags (e.g.
{#each}and{/each}), parameter declarations (e.g.{@org.acme.Foo foo}) and whitespace characters.
has a confusing and. I initially thought this applied to empty lines as well, but this test says it does not.
Perhaps the following is less confusing for people like me?
A standalone line is a line that contains at least one of: section tags (e.g.
{#each}and{/each}) or parameter declarations (e.g.{@org.acme.Foo foo}), ignoring any whitespace characters on the same line.
It's not perfect yet, though so if you find better, I'll take it :)
There was a problem hiding this comment.
Yeah, as I read it it's confusing... let's fix it!
mkouba
added
the
triage/waiting-for-ci
|
@mkouba all good no more line with the include inner block 🍻 |
|
@mkouba ready to merge :) |
