Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honour @JsonIgnore on Panache entities #10345

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 29, 2020

Fixes: #10339

@gastaldi
Copy link
Contributor

I may be wrong, but maybe @JsonbTransient would fall in the same case?

@gastaldi
Copy link
Contributor

Ah perhaps that is already done in:

// Apply JAX-B annotations that are being transferred from the field
for (EntityFieldAnnotation anno : field.annotations) {
anno.writeToVisitor(mv);
}

@geoand
Copy link
Contributor Author

geoand commented Jun 29, 2020

Theoretically yes, but Panache only adds the Jackson annotations to the generated bytecode, so if there is a problem with Jsonb, it's likely to be larger than this

@gastaldi gastaldi added this to the 1.7.0 - master milestone Jun 29, 2020
@FroMage FroMage merged commit 3f4f3ef into quarkusio:master Jun 30, 2020
@geoand geoand deleted the #10339 branch June 30, 2020 08:45
@gsmet gsmet modified the milestones: 1.7.0 - master, 1.6.0.Final Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@JsonIgnore on fields in panache entity not working
4 participants