Ensure that duplicates don't end up in dev mode CP in multi-module projects #10421
Conversation
boring-cyborg
bot
added
area/devtools
| // only add the artifact if it's present in the dev mode context | ||
| // we need this to avoid having jars on the classpath multiple times | ||
| if (!devModeContext.getLocalArtifacts().contains(new AppArtifactKey(appDep.getGroupId(), appDep.getArtifactId(), | ||
| appDep.getClassifier(), appDep.getType()))) { |
There was a problem hiding this comment.
appDep.getArtifactHandler().getExtension() perhaps would be a more accurate one.
There was a problem hiding this comment.
Didn't know that one, thanks!
|
This is a good candidate for 1.6.1, hence the backport label |
Just asking for sprint planning reasons: 1.6.0 is already "frozen"? |
Yup. We will only add bug fixes to 1.6.x releases (if needed) |
|
Now that's interesting and a bit confusing: In context of my CCE-problem with CXF, I tried out this PR branch and the behaviour changes: I now get a Runner-jar is still fine. 😕 I guess it is time to create a separate issue? |
Yup, with a reproducer if possible :) |
|
@aloubyansky Unfortunately not. It seems it really requires CXF which makes it harder to reproduce. Apart from that: This PR does fix #10411 for my internal project! Good work, thanks! Looking forward to 1.6.1. |
|
Darn CI failed... It was passing locally... So now I have to figure out what's going on |
|
Wait for the CI to finish, we'll check the logs. |
I'll take care of it, don't worry :) |
|
CI passed on my fork, so let's see what happens here |
geoand
added
the
triage/waiting-for-ci
I was able to reproduce the NPE initially when adding the test for quarkusio#10421. The way I got around it in that test was to make sure the compile phase was invoked
I was able to reproduce the NPE initially when adding the test for quarkusio#10421. The way I got around it in that test was to make sure the compile phase was invoked
I was able to reproduce the NPE initially when adding the test for quarkusio#10421. The way I got around it in that test was to make sure the compile phase was invoked
Fixes: #10411