Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST Data Panache dev mode #10431

Merged
merged 1 commit into from
Sep 29, 2020
Merged

REST Data Panache dev mode #10431

merged 1 commit into from
Sep 29, 2020

Conversation

gytis
Copy link

@gytis gytis commented Jul 2, 2020 •
edited
Loading

Fixes #9510.

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/panache labels Jul 2, 2020
@gsmet
Copy link
Member

gsmet commented Jul 27, 2020

@gytis I upgraded RESTEasy to 4.5.6.Final, is it enough for this to work?

@geoand
Copy link
Contributor

geoand commented Jul 27, 2020

@asoldano when is RESTEasy 4.6.0.Final due? If it's not out before we release Quarkus 1.7.0.CR1, I think it would be good to have a 4.5.7.Final with resteasy/resteasy@2bb4bc0 included (although I don't know how safe it is)

@gytis gytis mentioned this pull request Sep 22, 2020
Closed
@gytis gytis marked this pull request as ready for review September 29, 2020 12:37
@gytis
Copy link
Author

gytis commented Sep 29, 2020

@geoand this should be good to go now since the RESTEasy upgrade has been merged.

@geoand
Copy link
Contributor

geoand commented Sep 29, 2020

One question: You mention potential fix in the description, but if I recall correctly, this is the actual fix, right?

Asking because I want to know if we should properly link the issue so GH can close it when we merge the PR

@geoand
Copy link
Contributor

geoand commented Sep 29, 2020

Also, have you rebased the PR to the latest master? Best we have it up to date

@gytis
Copy link
Author

gytis commented Sep 29, 2020

My bad, I left the description unchanged. I've created this PR months ago to have it ready once the RESTEasy is upgraded.

@gytis
Copy link
Author

gytis commented Sep 29, 2020 •
edited
Loading

I've rebased a few hours ago. Should I do it again?

@geoand
Copy link
Contributor

geoand commented Sep 29, 2020

No, just wanted to make sure it wasn't weeks old 😎

@geoand geoand added this to the 1.9.0 - master milestone Sep 29, 2020
@geoand geoand merged commit ac0e934 into quarkusio:master Sep 29, 2020
@gytis gytis deleted the bug-fix-9510 branch September 30, 2020 09:06
@gsmet gsmet changed the title REST Data Panache dev mode fix #9510 REST Data Panache dev mode Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/panache
Projects
None yet
Milestone
1.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Error with HTTP POST using "REST Data with Panache" extension
3 participants
@gytis @gsmet @geoand