Allow Arc to deal with final methods of beans that need to be proxied #10497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
changed the title
|
@mkouba this probably could be a little cleaner, but I hope it's good enough for now :) |
mkouba
reviewed
Jul 7, 2020
Sure, I'll do that later on |
|
@mkouba PR updated with the doc suggestions you mentioned |
|
@mkouba OK to merge? |
mkouba
reviewed
Jul 8, 2020
| @@ -59,6 +59,9 @@ | |||
| * If set to true, the bytecode of unproxyable beans will be transformed. This ensures that a proxy/subclass | |||
| * can be created properly. If the value is set to false, then an exception is thrown at build time indicating that a | |||
| * subclass/proxy could not be created. | |||
| * | |||
| * Furthermore when enabled, this setting allows Quarkus to properly create regular scoped class beans whose methods | |||
There was a problem hiding this comment.
I was more thinking about a list of all transformations we do... final class, no-args constructors, final methods of bean classes (for proxies/subclasses). This sentence is more or less redundant.
This is done in the same manner that is already present for interceptors and is very useful for Kotlin code where methods are final by default Fixes: quarkusio#10290
geoand
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in the same manner that is already present for
interceptors and is very useful for Kotlin code where methods
are final by default
Fixes: #10290