Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip OIDC authentication if the tenant is disabled #10506

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Skip OIDC authentication if the tenant is disabled #10506

merged 1 commit into from
Jul 7, 2020

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin sberyozkin marked this pull request as ready for review July 6, 2020 21:40
@sberyozkin sberyozkin mentioned this pull request Jul 6, 2020
Closed
@sberyozkin
Copy link
Member Author

Hi @stuartwdouglas FYI, I've checked that getChallenge is called even if authenticate returns an empty SecurityIdentity with the proactive authentication (I wanted to update a PR to throw the exception if getChallenge was called in case of the dosabled tenant)

@stuartwdouglas stuartwdouglas added this to the 1.7.0 - master milestone Jul 7, 2020
@stuartwdouglas stuartwdouglas merged commit 2551954 into quarkusio:master Jul 7, 2020
@Sgitario Sgitario mentioned this pull request Jul 7, 2020
Closed
@sberyozkin sberyozkin deleted the oidc_disable_at_runtime branch September 16, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@pedroigor pedroigor Awaiting requested review from pedroigor

Assignees
No one assigned
Labels
area/oidc
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@sberyozkin @stuartwdouglas