Make sure --no-daemon does indeed get used when quarkus-platform-descriptor-json module is built #10508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e use of --no-daemon option when launching gradlew to download the gradle wrapper
boring-cyborg
bot
added
the
area/devtools
|
@jaikiran I'll try the branch today |
|
@jaikiran Thx btw!!! |
|
We should be fine with that value. If there were a problem, it would show up quickly in the CI runs :) |
|
@jaikiran That worked :) |
geoand
approved these changes
Jul 7, 2020
|
Glad to hear it worked. @galderz, thank you for testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10468 introduced the
--no-daemonflag to help with #10454. But for reasons noted here #10454 (comment), that flag is effectively a no-op in its current state (as shown here #10454 (comment)).The commit in this PR increases the default max heap size to something higher than
64mto make sure the--no-daemonoption does get honoured.I have tested this change locally and I can confirm that with this change the Gradle daemon process isn't launched or used. Whether or not this is the cause of the hang will be known once this gets tested by @galderz. But keeping the hang aside, if we do want
--no-daemon(which I think is the right thing) then we need to use this non-defaultXmxvalue too.