Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested interfaces in @ConfigProperties #10534

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Add support for nested interfaces in @ConfigProperties #10534

merged 1 commit into from
Jul 8, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 7, 2020 •
edited
Loading

Resolves: #10511

@boring-cyborg boring-cyborg bot added the area/arc Issue related to ARC (dependency injection) label Jul 7, 2020
@geoand geoand added this to the 1.7.0 - master milestone Jul 7, 2020
@geoand geoand requested a review from mkouba July 7, 2020 14:30
@geoand geoand mentioned this pull request Jul 7, 2020
Closed
@geoand
Copy link
Contributor Author

geoand commented Jul 8, 2020

The Gradle CI failure is completely unrelated

@geoand
Copy link
Contributor Author

geoand commented Jul 8, 2020 •
edited
Loading

@mkouba if you have a few minutes to review this I would be very grateful since if changes are needed, I won't be able to make them for a few days (I'll be on PTO).

Thanks!

mkouba
mkouba approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Except that it's not about sub-interfaces but nested interfaces ;-).

@geoand
Copy link
Contributor Author

geoand commented Jul 8, 2020

Right, I'm always terrible at naming, let me fix the names :)

@geoand geoand changed the title Add support for sub-interfaces in @ConfigProperties Add support for nested interfaces in @ConfigProperties Jul 8, 2020
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 8, 2020
@geoand geoand merged commit a091e7d into quarkusio:master Jul 8, 2020
@geoand geoand deleted the #10511 branch July 8, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Support configuration with nested interfaces
2 participants
@geoand @mkouba